Merge lp:~zsombi/ubuntu-ui-toolkit/separate-uitk-versions into lp:ubuntu-ui-toolkit/staging
| Status: | Merged | ||||
|---|---|---|---|---|---|
| Merged at revision: | 1501 | ||||
| Proposed branch: | lp:~zsombi/ubuntu-ui-toolkit/separate-uitk-versions | ||||
| Merge into: | lp:ubuntu-ui-toolkit/staging | ||||
| Prerequisite: | lp:~zsombi/ubuntu-ui-toolkit/fix-import-versions | ||||
| Diff against target: |
21182 lines (+18252/-1101) 194 files modified
components.api (+918/-365) debian/qtdeclarative5-ubuntu-ui-toolkit-plugin.install (+15/-10) documentation/ubuntu-theming.qdoc (+1/-1) documentation/ubuntu-ui-toolkit-common.qdocconf (+7/-1) examples/1.3/1.3.pro (+0/-10) examples/examples.pro (+7/-20) examples/locale/locale.qml (+1/-1) examples/ubuntu-ui-toolkit-gallery/Buttons.qml (+1/-1) examples/ubuntu-ui-toolkit-gallery/Dialog.qml (+1/-1) examples/ubuntu-ui-toolkit-gallery/Icons.qml (+2/-2) examples/ubuntu-ui-toolkit-gallery/ListItems.qml (+1/-1) examples/ubuntu-ui-toolkit-gallery/Pickers.qml (+12/-1) examples/ubuntu-ui-toolkit-gallery/Popover.qml (+1/-1) examples/ubuntu-ui-toolkit-gallery/Sheet.qml (+1/-1) examples/ubuntu-ui-toolkit-gallery/UbuntuListViews.qml (+1/-1) examples/ubuntu-ui-toolkit-gallery/ubuntu-ui-toolkit-gallery.qml (+1/-1) modules/Ubuntu/Components/1.0/1.0.pro (+2/-2) modules/Ubuntu/Components/1.1/1.1.pro (+2/-2) modules/Ubuntu/Components/1.1/Haptics.qml (+1/-1) modules/Ubuntu/Components/1.2/1.2.pro (+15/-0) modules/Ubuntu/Components/1.2/AbstractButton.qml (+109/-0) modules/Ubuntu/Components/1.2/ActionItem.qml (+96/-0) modules/Ubuntu/Components/1.2/ActionList.qml (+47/-0) modules/Ubuntu/Components/1.2/ActivityIndicator.qml (+59/-0) modules/Ubuntu/Components/1.2/AnimatedItem.qml (+37/-0) modules/Ubuntu/Components/1.2/AppHeader.qml (+258/-0) modules/Ubuntu/Components/1.2/Captions.qml (+150/-0) modules/Ubuntu/Components/1.2/CheckBox.qml (+53/-0) modules/Ubuntu/Components/1.2/ComboButton.qml (+367/-0) modules/Ubuntu/Components/1.2/CrossFadeImage10.qml (+173/-0) modules/Ubuntu/Components/1.2/CrossFadeImage11.qml (+192/-0) modules/Ubuntu/Components/1.2/DraggingArea.qml (+114/-0) modules/Ubuntu/Components/1.2/Header.qml (+39/-0) modules/Ubuntu/Components/1.2/InputHandler.qml (+518/-0) modules/Ubuntu/Components/1.2/Label.qml (+59/-0) modules/Ubuntu/Components/1.2/MainView.qml (+1/-1) modules/Ubuntu/Components/1.2/MainView12.qml (+163/-0) modules/Ubuntu/Components/1.2/MainViewBase.qml (+83/-0) modules/Ubuntu/Components/1.2/OptionSelector.qml (+297/-0) modules/Ubuntu/Components/1.2/OptionSelectorDelegate.qml (+365/-0) modules/Ubuntu/Components/1.2/OrientationHelper.qml (+205/-0) modules/Ubuntu/Components/1.2/Page10.qml (+32/-5) modules/Ubuntu/Components/1.2/Page11.qml (+2/-4) modules/Ubuntu/Components/1.2/PageHeadConfiguration.qml (+207/-0) modules/Ubuntu/Components/1.2/PageHeadSections.qml (+78/-0) modules/Ubuntu/Components/1.2/PageHeadState.qml (+113/-0) modules/Ubuntu/Components/1.2/PageStack.qml (+304/-0) modules/Ubuntu/Components/1.2/PageTreeNode.qml (+158/-0) modules/Ubuntu/Components/1.2/PageWrapper.qml (+99/-0) modules/Ubuntu/Components/1.2/Panel.qml (+646/-0) modules/Ubuntu/Components/1.2/ProgressBar10.qml (+68/-0) modules/Ubuntu/Components/1.2/ProgressBar11.qml (+21/-0) modules/Ubuntu/Components/1.2/PullToRefresh.qml (+242/-0) modules/Ubuntu/Components/1.2/Scrollbar.qml (+150/-0) modules/Ubuntu/Components/1.2/Slider.qml (+211/-0) modules/Ubuntu/Components/1.2/Switch.qml (+44/-0) modules/Ubuntu/Components/1.2/Tab.qml (+168/-0) modules/Ubuntu/Components/1.2/TabBar.qml (+167/-0) modules/Ubuntu/Components/1.2/Tabs.qml (+448/-0) modules/Ubuntu/Components/1.2/TextArea.qml (+877/-0) modules/Ubuntu/Components/1.2/TextCursor.qml (+318/-0) modules/Ubuntu/Components/1.2/TextField.qml (+1023/-0) modules/Ubuntu/Components/1.2/TextInputPopover.qml (+103/-0) modules/Ubuntu/Components/1.2/Toolbar.qml (+147/-0) modules/Ubuntu/Components/1.2/ToolbarButton.qml (+87/-0) modules/Ubuntu/Components/1.2/ToolbarItems.qml (+224/-0) modules/Ubuntu/Components/1.2/UbuntuListView.qml (+143/-0) modules/Ubuntu/Components/1.2/UbuntuListView11.qml (+33/-0) modules/Ubuntu/Components/1.2/UbuntuNumberAnimation.qml (+56/-0) modules/Ubuntu/Components/1.3/1.3.pro (+15/-0) modules/Ubuntu/Components/1.3/AppHeader.qml (+1/-1) modules/Ubuntu/Components/1.3/Button.qml (+126/-0) modules/Ubuntu/Components/1.3/ComboButton.qml (+3/-4) modules/Ubuntu/Components/1.3/DraggingArea.qml (+1/-2) modules/Ubuntu/Components/1.3/MainView.qml (+1/-1) modules/Ubuntu/Components/1.3/OptionSelector.qml (+1/-1) modules/Ubuntu/Components/1.3/OptionSelectorDelegate.qml (+1/-1) modules/Ubuntu/Components/1.3/Page.qml (+1/-1) modules/Ubuntu/Components/1.3/PageHeadConfiguration.qml (+32/-3) modules/Ubuntu/Components/1.3/PageStack.qml (+2/-2) modules/Ubuntu/Components/1.3/PageTreeNode.qml (+2/-2) modules/Ubuntu/Components/1.3/PageWrapper.qml (+2/-2) modules/Ubuntu/Components/1.3/ProgressBar.qml (+56/-2) modules/Ubuntu/Components/1.3/PullToRefresh.qml (+3/-3) modules/Ubuntu/Components/1.3/Slider.qml (+1/-2) modules/Ubuntu/Components/1.3/Tab.qml (+1/-1) modules/Ubuntu/Components/1.3/Tabs.qml (+3/-2) modules/Ubuntu/Components/1.3/TextArea.qml (+2/-3) modules/Ubuntu/Components/1.3/TextCursor.qml (+1/-1) modules/Ubuntu/Components/1.3/TextField.qml (+2/-2) modules/Ubuntu/Components/1.3/TextInputPopover.qml (+1/-1) modules/Ubuntu/Components/1.3/ToolbarItems.qml (+1/-1) modules/Ubuntu/Components/1.3/UbuntuColors.qml (+132/-0) modules/Ubuntu/Components/1.3/UbuntuListView.qml (+1/-1) modules/Ubuntu/Components/ComponentModule.pro (+1/-9) modules/Ubuntu/Components/Components.pro (+4/-2) modules/Ubuntu/Components/CrossFadeImage10.qml (+0/-173) modules/Ubuntu/Components/ListItems/1.2/1.2.pro (+15/-0) modules/Ubuntu/Components/ListItems/1.2/Base.qml (+183/-0) modules/Ubuntu/Components/ListItems/1.2/Caption.qml (+59/-0) modules/Ubuntu/Components/ListItems/1.2/Divider.qml (+36/-0) modules/Ubuntu/Components/ListItems/1.2/Empty.qml (+486/-0) modules/Ubuntu/Components/ListItems/1.2/Expandable.qml (+221/-0) modules/Ubuntu/Components/ListItems/1.2/ExpandablesColumn.qml (+131/-0) modules/Ubuntu/Components/ListItems/1.2/Header.qml (+77/-0) modules/Ubuntu/Components/ListItems/1.2/IconVisual.qml (+58/-0) modules/Ubuntu/Components/ListItems/1.2/ImageWithFallback.qml (+46/-0) modules/Ubuntu/Components/ListItems/1.2/ItemSelector.qml (+286/-0) modules/Ubuntu/Components/ListItems/1.2/LabelVisual.qml (+38/-0) modules/Ubuntu/Components/ListItems/1.2/MultiValue.qml (+95/-0) modules/Ubuntu/Components/ListItems/1.2/ProgressionVisual.qml (+29/-0) modules/Ubuntu/Components/ListItems/1.2/SingleControl.qml (+79/-0) modules/Ubuntu/Components/ListItems/1.2/SingleValue.qml (+81/-0) modules/Ubuntu/Components/ListItems/1.2/Standard.qml (+304/-0) modules/Ubuntu/Components/ListItems/1.2/Subtitled.qml (+112/-0) modules/Ubuntu/Components/ListItems/1.2/ThinDivider.qml (+64/-0) modules/Ubuntu/Components/ListItems/1.2/ValueSelector.qml (+297/-0) modules/Ubuntu/Components/ListItems/1.3/1.3.pro (+15/-0) modules/Ubuntu/Components/ListItems/1.3/Caption.qml (+1/-1) modules/Ubuntu/Components/ListItems/1.3/Divider.qml (+1/-1) modules/Ubuntu/Components/ListItems/1.3/Empty.qml (+2/-2) modules/Ubuntu/Components/ListItems/1.3/Expandable.qml (+1/-1) modules/Ubuntu/Components/ListItems/1.3/ExpandablesColumn.qml (+1/-1) modules/Ubuntu/Components/ListItems/1.3/Header.qml (+1/-1) modules/Ubuntu/Components/ListItems/1.3/ItemSelector.qml (+1/-1) modules/Ubuntu/Components/ListItems/1.3/MultiValue.qml (+1/-1) modules/Ubuntu/Components/ListItems/1.3/SingleControl.qml (+2/-2) modules/Ubuntu/Components/ListItems/1.3/SingleValue.qml (+1/-1) modules/Ubuntu/Components/ListItems/1.3/Standard.qml (+1/-1) modules/Ubuntu/Components/ListItems/1.3/Subtitled.qml (+1/-1) modules/Ubuntu/Components/ListItems/1.3/ThinDivider.qml (+1/-1) modules/Ubuntu/Components/ListItems/1.3/ValueSelector.qml (+2/-2) modules/Ubuntu/Components/ListItems/ListItems.pro (+5/-25) modules/Ubuntu/Components/ListItems/ListItemsModule.pro (+13/-0) modules/Ubuntu/Components/ListItems/qmldir (+48/-30) modules/Ubuntu/Components/PageHeadConfiguration11.qml (+0/-55) modules/Ubuntu/Components/Pickers/1.2/1.2.pro (+15/-0) modules/Ubuntu/Components/Pickers/1.2/DatePicker.qml (+672/-0) modules/Ubuntu/Components/Pickers/1.2/DayModel.qml (+86/-0) modules/Ubuntu/Components/Pickers/1.2/Dialer.qml (+179/-0) modules/Ubuntu/Components/Pickers/1.2/DialerHand.qml (+224/-0) modules/Ubuntu/Components/Pickers/1.2/DialerHandGroup.qml (+29/-0) modules/Ubuntu/Components/Pickers/1.2/HoursModel.qml (+63/-0) modules/Ubuntu/Components/Pickers/1.2/MinutesModel.qml (+63/-0) modules/Ubuntu/Components/Pickers/1.2/MonthModel.qml (+98/-0) modules/Ubuntu/Components/Pickers/1.2/Picker.qml (+447/-0) modules/Ubuntu/Components/Pickers/1.2/PickerDelegate.qml (+58/-0) modules/Ubuntu/Components/Pickers/1.2/PickerModelBase.qml (+154/-0) modules/Ubuntu/Components/Pickers/1.2/PickerPanel.qml (+267/-0) modules/Ubuntu/Components/Pickers/1.2/PickerRow.qml (+137/-0) modules/Ubuntu/Components/Pickers/1.2/SecondsModel.qml (+63/-0) modules/Ubuntu/Components/Pickers/1.2/YearModel.qml (+69/-0) modules/Ubuntu/Components/Pickers/1.3/1.3.pro (+15/-0) modules/Ubuntu/Components/Pickers/1.3/PickerPanel.qml (+2/-2) modules/Ubuntu/Components/Pickers/Pickers.pro (+5/-25) modules/Ubuntu/Components/Pickers/PickersModule.pro (+14/-0) modules/Ubuntu/Components/Pickers/qmldir (+21/-16) modules/Ubuntu/Components/Popups/1.2/1.2.pro (+15/-0) modules/Ubuntu/Components/Popups/1.2/ActionSelectionPopover.qml (+165/-0) modules/Ubuntu/Components/Popups/1.2/ComposerSheet.qml (+97/-0) modules/Ubuntu/Components/Popups/1.2/DefaultSheet.qml (+104/-0) modules/Ubuntu/Components/Popups/1.2/Dialog.qml (+218/-0) modules/Ubuntu/Components/Popups/1.2/Popover.qml (+300/-0) modules/Ubuntu/Components/Popups/1.2/PopupBase.qml (+261/-0) modules/Ubuntu/Components/Popups/1.2/SheetBase.qml (+113/-0) modules/Ubuntu/Components/Popups/1.2/internalPopupUtils.js (+290/-0) modules/Ubuntu/Components/Popups/1.3/1.3.pro (+15/-0) modules/Ubuntu/Components/Popups/1.3/ActionSelectionPopover.qml (+1/-1) modules/Ubuntu/Components/Popups/1.3/ComposerSheet.qml (+1/-1) modules/Ubuntu/Components/Popups/1.3/DefaultSheet.qml (+1/-1) modules/Ubuntu/Components/Popups/1.3/Dialog.qml (+1/-1) modules/Ubuntu/Components/Popups/1.3/Popover.qml (+2/-2) modules/Ubuntu/Components/Popups/1.3/internalPopupUtils.js (+5/-5) modules/Ubuntu/Components/Popups/PopupModule.pro (+14/-0) modules/Ubuntu/Components/Popups/Popups.pro (+5/-25) modules/Ubuntu/Components/Popups/qmldir (+27/-17) modules/Ubuntu/Components/ProgressBar10.qml (+0/-69) modules/Ubuntu/Components/ProgressBar11.qdoc (+0/-6) modules/Ubuntu/Components/Styles/1.2/1.2.pro (+11/-0) modules/Ubuntu/Components/Styles/Styles.pro (+4/-25) modules/Ubuntu/Components/Styles/StylesModule.pro (+25/-0) modules/Ubuntu/Components/Styles/qmldir (+5/-3) modules/Ubuntu/Components/Themes/Ambiance/1.3/DatePickerStyle.qml (+1/-1) modules/Ubuntu/Components/Themes/Ambiance/1.3/OverflowPanel.qml (+2/-2) modules/Ubuntu/Components/Themes/Ambiance/1.3/PageHeadStyle.qml (+3/-3) modules/Ubuntu/Components/Themes/Ambiance/1.3/PickerStyle.qml (+1/-1) modules/Ubuntu/Components/plugin/plugin.cpp (+9/-1) modules/Ubuntu/Components/plugin/plugin.h (+1/-0) modules/Ubuntu/Components/qmldir (+131/-103) modules/Ubuntu/PerformanceMetrics/BarGraph.qml (+1/-1) tests/autopilot/ubuntuuitoolkit/tests/gallery/__init__.py (+2/-3) tests/unit/runtest.sh (+1/-1) tests/unit_x11/tst_components/tst_header_contents_width.qml (+2/-2) tests/unit_x11/tst_components/tst_pagestack.new_header.qml (+1/-1) |
||||
| To merge this branch: | bzr merge lp:~zsombi/ubuntu-ui-toolkit/separate-uitk-versions | ||||
| Related bugs: |
|
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| PS Jenkins bot | continuous-integration | Needs Fixing on 2015-05-07 | |
| Christian Dywan | 2015-04-25 | Approve on 2015-05-06 | |
|
Review via email:
|
|||
Commit Message
Separate 1.2 from 1.3 versions in all Ubuntu.Component modules.
| PS Jenkins bot (ps-jenkins) wrote : | # |
FAILED: Continuous integration, rev:1529
http://
Executed test runs:
FAILURE: http://
FAILURE: http://
FAILURE: http://
FAILURE: http://
FAILURE: http://
Click here to trigger a rebuild:
http://
| Christian Dywan (kalikiana) wrote : | # |
dh_install: qtdeclarative5-
You moved modules/
Remember, you can use "bzr bd" to spot this more quickly as you won't have to wait for J to finish if it's just packaging changes.
| Christian Dywan (kalikiana) wrote : | # |
examples/
Do we really have to duplicate translations? It should be fine to share strings and translators will appreciate not having to go through an exponential increase in strings.
| Zsombor Egri (zsombi) wrote : | # |
> dh_install: qtdeclarative5-
> (usr/lib/
>
> You moved modules/
> move to Comoponents/ but didn't update .install - by accident?
>
> Remember, you can use "bzr bd" to spot this more quickly as you won't have to
> wait for J to finish if it's just packaging changes.
I wish I could, I tried, it fails building even on a perfect branch :/
| Zsombor Egri (zsombi) wrote : | # |
> examples/
>
> Do we really have to duplicate translations? It should be fine to share
> strings and translators will appreciate not having to go through an
> exponential increase in strings.
I have chosen the easiest way no, we can shape it if we want to later. We can share, of course, but we may also have to add more stuff to the newer releases, so why do share?
Also, the gallery needs to be redesigned from the grounds, so we use Layouts, etc. And that is better to do in a separate branch too.
| Christian Dywan (kalikiana) wrote : | # |
> > examples/
> >
> > Do we really have to duplicate translations? It should be fine to share
> > strings and translators will appreciate not having to go through an
> > exponential increase in strings.
>
> I have chosen the easiest way no, we can shape it if we want to later. We can
> share, of course, but we may also have to add more stuff to the newer
> releases, so why do share?
That really depends on what we do with it. Will we maintain additions to each copy and run all AP tests against multiple versions for compatibility testing? How many varianrts will we have? Which one will app developers read when looking for example code?
In that sense, multiplying the amount of translatable strings is not my only concern, but the most obvious problem.
> Also, the gallery needs to be redesigned from the grounds, so we use Layouts,
> etc. And that is better to do in a separate branch too.
For that matter, I don't see why the gallery has to be duplicated in this step. We've had good arguments to do that before the version revamp and didn't do it. Again my main concern is doing this by the way with no clear plan.
| PS Jenkins bot (ps-jenkins) wrote : | # |
FAILED: Continuous integration, rev:1530
http://
Executed test runs:
UNSTABLE: http://
UNSTABLE: http://
UNSTABLE: http://
deb: http://
UNSTABLE: http://
UNSTABLE: http://
SUCCESS: http://
deb: http://
SUCCESS: http://
Click here to trigger a rebuild:
http://
| PS Jenkins bot (ps-jenkins) wrote : | # |
FAILED: Continuous integration, rev:1531
http://
Executed test runs:
UNSTABLE: http://
UNSTABLE: http://
UNSTABLE: http://
deb: http://
UNSTABLE: http://
UNSTABLE: http://
SUCCESS: http://
deb: http://
SUCCESS: http://
Click here to trigger a rebuild:
http://
| PS Jenkins bot (ps-jenkins) wrote : | # |
FAILED: Continuous integration, rev:1532
http://
Executed test runs:
UNSTABLE: http://
UNSTABLE: http://
UNSTABLE: http://
deb: http://
UNSTABLE: http://
UNSTABLE: http://
SUCCESS: http://
deb: http://
SUCCESS: http://
Click here to trigger a rebuild:
http://
| Christian Dywan (kalikiana) wrote : | # |
The on-going outages in CI make me uneasy… other than that the branch looks good and I didn't spot any genuine failures.
| Zoltan Balogh (bzoltan) wrote : | # |
> The on-going outages in CI make me uneasy… other than that the branch looks
> good and I didn't spot any genuine failures.
Well :) The bz push is always at our disposal... but it would be nice to see a clean merge executed by Jenkins.
| PS Jenkins bot (ps-jenkins) wrote : | # |
FAILED: Autolanding.
More details in the following jenkins job:
http://
Executed test runs:
UNSTABLE: http://
UNSTABLE: http://
deb: http://
UNSTABLE: http://
| PS Jenkins bot (ps-jenkins) wrote : | # |
FAILED: Continuous integration, rev:1532
http://
Executed test runs:
UNSTABLE: http://
UNSTABLE: http://
UNSTABLE: http://
deb: http://
UNSTABLE: http://
UNSTABLE: http://
SUCCESS: http://
deb: http://
SUCCESS: http://
Click here to trigger a rebuild:
http://
| PS Jenkins bot (ps-jenkins) wrote : | # |
FAILED: Continuous integration, rev:1532
http://
Executed test runs:
FAILURE: http://
UNSTABLE: http://
UNSTABLE: http://
deb: http://
UNSTABLE: http://
FAILURE: http://
SUCCESS: http://
deb: http://
SUCCESS: http://
Click here to trigger a rebuild:
http://
| PS Jenkins bot (ps-jenkins) wrote : | # |
FAILED: Continuous integration, rev:1532
http://
Executed test runs:
UNSTABLE: http://
UNSTABLE: http://
UNSTABLE: http://
deb: http://
UNSTABLE: http://
UNSTABLE: http://
SUCCESS: http://
deb: http://
SUCCESS: http://
Click here to trigger a rebuild:
http://
| PS Jenkins bot (ps-jenkins) wrote : | # |
FAILED: Continuous integration, rev:1532
http://
Executed test runs:
UNSTABLE: http://
UNSTABLE: http://
UNSTABLE: http://
deb: http://
UNSTABLE: http://
UNSTABLE: http://
SUCCESS: http://
deb: http://
SUCCESS: http://
Click here to trigger a rebuild:
http://

FAILED: Continuous integration, rev:1528 jenkins. qa.ubuntu. com/job/ ubuntu- sdk-team- ubuntu- ui-toolkit- staging- ci/1735/ jenkins. qa.ubuntu. com/job/ generic- deb-autopilot- vivid-touch/ 2620/console jenkins. qa.ubuntu. com/job/ ubuntu- sdk-team- ubuntu- ui-toolkit- staging- vivid-amd64- ci/463/ console jenkins. qa.ubuntu. com/job/ ubuntu- sdk-team- ubuntu- ui-toolkit- staging- vivid-armhf- ci/465/ console jenkins. qa.ubuntu. com/job/ ubuntu- sdk-team- ubuntu- ui-toolkit- staging- vivid-i386- ci/462/ console jenkins. qa.ubuntu. com/job/ generic- mediumtests- builder- vivid-armhf/ 2618/console
http://
Executed test runs:
FAILURE: http://
FAILURE: http://
FAILURE: http://
FAILURE: http://
FAILURE: http://
Click here to trigger a rebuild: s-jenkins. ubuntu- ci:8080/ job/ubuntu- sdk-team- ubuntu- ui-toolkit- staging- ci/1735/ rebuild
http://