Merge lp:~zsombi/ubuntu-ui-toolkit/mainview-rtl into lp:ubuntu-ui-toolkit/staging

Proposed by Zsombor Egri
Status: Work in progress
Proposed branch: lp:~zsombi/ubuntu-ui-toolkit/mainview-rtl
Merge into: lp:ubuntu-ui-toolkit/staging
Diff against target: 14 lines (+4/-0)
1 file modified
modules/Ubuntu/Components/MainViewBase.qml (+4/-0)
To merge this branch: bzr merge lp:~zsombi/ubuntu-ui-toolkit/mainview-rtl
Reviewer Review Type Date Requested Status
Cris Dywan Needs Fixing
PS Jenkins bot continuous-integration Needs Fixing
Review via email: mp+251420@code.launchpad.net

Commit message

Provide app-wide LayoutMirroring triggering from MainView.

To post a comment you must log in.
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Needs Fixing (continuous-integration)
Revision history for this message
Cris Dywan (kalikiana) wrote :

Do we still want to have this out of the box? If so it needs some test cases.

review: Needs Fixing

Unmerged revisions

1425. By Zsombor Egri

adding layout mirrorring condition to MainViewBase

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'modules/Ubuntu/Components/MainViewBase.qml'
2--- modules/Ubuntu/Components/MainViewBase.qml 2015-02-12 11:19:57 +0000
3+++ modules/Ubuntu/Components/MainViewBase.qml 2015-03-02 09:38:38 +0000
4@@ -29,6 +29,10 @@
5 property alias backgroundColor: background.backgroundColor
6 property alias footerColor: background.footerColor
7
8+ // RTL support
9+ LayoutMirroring.enabled: Qt.application.layoutDirection == Qt.RightToLeft
10+ LayoutMirroring.childrenInherit: true
11+
12 // FIXME: Make sure that the theming is only in the background, and the style
13 // should not occlude contents of the MainView. When making changes here, make
14 // sure that bug https://bugs.launchpad.net/manhattan/+bug/1124076 does not come back.

Subscribers

People subscribed via source and target branches