Merge lp:~zsombi/ubuntu-ui-toolkit/inverseMouseArea-update into lp:~bzoltan/ubuntu-ui-toolkit/landing_04-06

Proposed by Zsombor Egri
Status: Merged
Merged at revision: 1097
Proposed branch: lp:~zsombi/ubuntu-ui-toolkit/inverseMouseArea-update
Merge into: lp:~bzoltan/ubuntu-ui-toolkit/landing_04-06
Diff against target: 51 lines (+5/-4)
2 files modified
modules/Ubuntu/Components/plugin/inversemouseareatype.cpp (+4/-3)
modules/Ubuntu/Components/plugin/inversemouseareatype.h (+1/-1)
To merge this branch: bzr merge lp:~zsombi/ubuntu-ui-toolkit/inverseMouseArea-update
Reviewer Review Type Date Requested Status
Tim Peeters (community) Approve
Zoltan Balogh Pending
Review via email: mp+223589@code.launchpad.net

Commit message

Reverting InverseMouseAreaType updateArea() method to update(). Calling shadowed superclass' update() method.

To post a comment you must log in.
Revision history for this message
Tim Peeters (tpeeters) wrote :

that makes sense

review: Approve
Revision history for this message
Tim Peeters (tpeeters) wrote :

this makes sense:

17:53:23 < elopio> t1mp: nice! would it be too much to ask for a regression test?
17:53:50 < elopio> otherwise, we might still be suffering with notes erros on the releases.

Revision history for this message
Tim Peeters (tpeeters) wrote :

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'modules/Ubuntu/Components/plugin/inversemouseareatype.cpp'
2--- modules/Ubuntu/Components/plugin/inversemouseareatype.cpp 2014-06-09 08:26:24 +0000
3+++ modules/Ubuntu/Components/plugin/inversemouseareatype.cpp 2014-06-18 15:29:40 +0000
4@@ -276,7 +276,7 @@
5 \internal
6 Slot connected to enabledChanged signal to update the state of the handler.
7 */
8-void InverseMouseAreaType::updateArea()
9+void InverseMouseAreaType::update()
10 {
11 if (!m_ready) {
12 return;
13@@ -286,6 +286,7 @@
14 m_sensingArea = QuickUtils::instance().rootItem(this);
15 }
16 updateEventFilter(isEnabled() && isVisible() && m_topmostItem);
17+ QQuickMouseArea::update();
18 }
19 /*!
20 \internal
21@@ -300,7 +301,7 @@
22 void InverseMouseAreaType::itemChange(ItemChange change, const ItemChangeData &data)
23 {
24 if (change == ItemParentHasChanged && data.item) {
25- updateArea();
26+ update();
27 }
28 QQuickMouseArea::itemChange(change, data);
29 }
30@@ -311,7 +312,7 @@
31 // by now the parents should have been resolved so we can look after the
32 // topmost component for the sensingArea in case it has not been set yet
33 m_ready = true;
34- updateArea();
35+ update();
36 }
37
38 /*
39
40=== modified file 'modules/Ubuntu/Components/plugin/inversemouseareatype.h'
41--- modules/Ubuntu/Components/plugin/inversemouseareatype.h 2014-06-09 08:26:24 +0000
42+++ modules/Ubuntu/Components/plugin/inversemouseareatype.h 2014-06-18 15:29:40 +0000
43@@ -53,7 +53,7 @@
44 void topmostItemChanged();
45
46 private Q_SLOTS:
47- void updateArea();
48+ void update();
49 void resetFilterOnWindowUpdate(QQuickWindow *win);
50
51 private:

Subscribers

People subscribed via source and target branches

to all changes: