lp:~zsombi/ubuntu-ui-toolkit/focusInComponents

Branch merges

Propose for merging

No branches dependent on this one.

Merged into lp:ubuntu-ui-toolkit/staging at revision 2109

ubuntu-sdk-build-bot: Approve (continuous-integration) on 2016-09-19

Cris Dywan: Approve on 2016-09-19

Diff: 227 lines (+80/-7)

14 files modified

src/UbuntuToolkit/ucbottomedgehint.cpp (+3/-0)
src/imports/Components/1.3/Button.qml (+1/-0)
src/imports/Components/1.3/CheckBox.qml (+1/-0)
src/imports/Components/1.3/ComboButton.qml (+1/-0)
src/imports/Components/1.3/Slider.qml (+1/-0)
src/imports/Components/1.3/TextArea.qml (+1/-0)
src/imports/Components/1.3/TextField.qml (+1/-0)
src/imports/Components/Themes/Ambiance/1.3/ActionBarStyle.qml (+1/-0)
src/imports/Components/Themes/Ambiance/1.3/FocusShape.qml (+0/-7)
src/imports/Components/Themes/Ambiance/1.3/PageHeadStyle.qml (+1/-0)
src/imports/Components/Themes/Ambiance/1.3/PageHeaderStyle.qml (+1/-0)
src/imports/Components/Themes/Ambiance/1.3/ToolbarStyle.qml (+1/-0)
tests/unit/visual/tst_actionbar.13.qml (+1/-0)
tests/unit/visual/tst_listitem_horizontal_navigation.13.qml (+66/-0)

api

Related source package recipes

No recipes using this branch. (?)

Create packaging recipe

Related snap packages

Related bugs

Bug #1590005: Focus can go be moved inside ListItem in a horizontal ListView

High

Fix Released

Link a bug report

Related blueprints

2104. By Zsombor Egri on 2016-09-19

move focus driving to the components, style should only react on those

2103. By Zsombor Egri on 2016-09-16

staging sync

2102. By Zsombor Egri on 2016-09-16

staging sync

2101. By Zsombor Egri on 2016-09-15

'bug'

2100. By Cris Dywan on 2016-09-13

Correctly test and fix trigger override of ComboButton. Fixes: https://bugs.launchpad.net/bugs/1614045.

Approved by ubuntu-sdk-build-bot, Zsombor Egri.

2099. By Loïc Molinari on 2016-09-13

Made use of Qt builtin to check GCC version.

Approved by ubuntu-sdk-build-bot, Benjamin Zeller.

2098. By Loïc Molinari on 2016-09-13

Cleaned up ubuntu_qt_module.prf and the libs using it.

1/ Moved the common config options from the pro files to the prf file to avoid duplications and simplify the files.

2/ Removed the useless "TEMPLATE=lib" and "load(qt_build_config)" lines from the pro files since it's done for us by qt_module.prf.

3/ Use QT= instead of QT*= since it's well defined that by default its content is "core gui".

4/ Prefixed headers and sources by $$PWD/ and sorted the lines alphabetically.

5/ Merged the SOURCES declarations in UbuntuToolkit.pro.

6/ Removed the useless "DEFINES += QT_USE_QSTRINGBUILDER" line from UbuntuToolkit.pro since it's done for us by qt_module.prf.

7/ Removed the useless "QMAKE_CXXFLAGS -= -Werror=deprecated-declarations" and "DEFINES -= QT_DEPRECATED_WARNINGS" lines from UbuntuToolkit.pro since it's already done in ubuntu_qt_module.prf.

8/ Added a few comments.

Approved by ubuntu-sdk-build-bot, Zsombor Egri.

2097. By Loïc Molinari on 2016-09-12

Fixed, cleaned up and standardised header inclusions.

Apart from the clean up and the readability improvements, this fixes a bunch of broken private header inclusions (#include "foo_p.h" in private headers instead of "private/foo_p.h" or better <Project/private/foo_p.h>), now all the private headers of the UITK can be included by the users withour compilation issues. It also removes a bunch of direct includes from sources and a few INCLUDEPATHs hacks.

See the CODING file for more details.

Approved by ubuntu-sdk-build-bot, Zsombor Egri.

2096. By Tim Peeters on 2016-09-12

Use the new arrow icons from the suru-icon-theme in the scrolling ActionBar.

Approved by ubuntu-sdk-build-bot, Zoltan Balogh.

2095. By Zsombor Egri on 2016-09-08

New visuals for ProgressBar. Fixes: https://bugs.launchpad.net/bugs/1587176.

Approved by ubuntu-sdk-build-bot, Christian Dywan.