Merge lp:~zsombi/ubuntu-ui-toolkit/fixComboButton into lp:ubuntu-ui-toolkit
Proposed by
Zsombor Egri
Status: | Merged | ||||
---|---|---|---|---|---|
Approved by: | Zoltan Balogh | ||||
Approved revision: | 1315 | ||||
Merged at revision: | 1316 | ||||
Proposed branch: | lp:~zsombi/ubuntu-ui-toolkit/fixComboButton | ||||
Merge into: | lp:ubuntu-ui-toolkit | ||||
Diff against target: |
259 lines (+244/-0) 2 files modified
src/Ubuntu/Components/1.3/ComboButton.qml (+9/-0) tests/unit_x11/tst_components/tst_combobutton13.qml (+235/-0) |
||||
To merge this branch: | bzr merge lp:~zsombi/ubuntu-ui-toolkit/fixComboButton | ||||
Related bugs: |
|
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Renato Araujo Oliveira Filho (community) | test | Approve | |
PS Jenkins bot | continuous-integration | Needs Fixing | |
Ubuntu SDK team | Pending | ||
Review via email: mp+294387@code.launchpad.net |
Commit message
Fix regression introduced in ComboButton due to the binding loop bug on AbstractButton implicit sizes.
To post a comment you must log in.
FAILED: Continuous integration, rev:1315 jenkins. qa.ubuntu. com/job/ ubuntu- ui-toolkit- ci/2325/ jenkins. qa.ubuntu. com/job/ ubuntu- ui-toolkit- vivid-amd64- ci/148/ console jenkins. qa.ubuntu. com/job/ ubuntu- ui-toolkit- vivid-armhf- ci/149/ console
http://
Executed test runs:
FAILURE: http://
FAILURE: http://
Click here to trigger a rebuild: s-jenkins. ubuntu- ci:8080/ job/ubuntu- ui-toolkit- ci/2325/ rebuild
http://