Code review comment for lp:~zsombi/ubuntu-ui-toolkit/fix-import-versions

Revision history for this message
Cris Dywan (kalikiana) wrote :

why examples/1.3? seems a bit pointless if we won't have any old ones

- 191 return QUrl::fromLocalFile(absoluteThemeFolder);
+ 189 record.deprecated = QFile::exists(absoluteThemeFolder + "deprecated");
+ 190 record.path = QUrl::fromLocalFile(absoluteThemeFolder);
+ 191 break;

At first glance this seems a bit ugly, though I can live with it. I think we should have a bug about adding this flag to theme meta data eventually - which we'll need once third party themes can be installed and then we won't need this magic file anymore.

+ 706 qmlInfo(parent) << QStringLiteral("Theme '%1' has no '%2' style for version %3.%4, fall back to version %5.%6.")

Should/ could we have a specific warning about the theme being deprecated? So it's clear to an app developer that for instance they should stop using SuruGradient, and not just ponder why it's "incomplete".

review: Needs Information

« Back to merge proposal