Code review comment for lp:~zsombi/ubuntu-ui-toolkit/dynamic-tabs

Revision history for this message
Zsombor Egri (zsombi) wrote :

> 315 + function dymanicRemove() {
> 316 + for (var i in tabStack.children) {
> 317 + if (this === tabStack.children[i]) {
> 318 + tabs.removeTab(i);
> 319 + break;
> 320 }
>
>
> That's a bit confusing for me. What is 'this' here?
'this' is the caller object, to which the function was bent to. However this is not needed as we assume tabs are either pre-declared or created by the Tabs functions. So I removed the relevant functionality in revno 826.

« Back to merge proposal