Merge lp:~zsombi/ubuntu-ui-toolkit/datePickerTestFailure into lp:ubuntu-ui-toolkit

Proposed by Zsombor Egri
Status: Merged
Approved by: Cris Dywan
Approved revision: 902
Merged at revision: 901
Proposed branch: lp:~zsombi/ubuntu-ui-toolkit/datePickerTestFailure
Merge into: lp:ubuntu-ui-toolkit
Diff against target: 11 lines (+1/-0)
1 file modified
tests/unit_x11/tst_components/tst_datepicker.qml (+1/-0)
To merge this branch: bzr merge lp:~zsombi/ubuntu-ui-toolkit/datePickerTestFailure
Reviewer Review Type Date Requested Status
PS Jenkins bot continuous-integration Approve
Cris Dywan Approve
Review via email: mp+200675@code.launchpad.net

Commit message

DatePicker test case fix, setting the minimum limit to value that is earlier than the date value set.

To post a comment you must log in.
Revision history for this message
Cris Dywan (kalikiana) wrote :

Oh! So this actually is because the minimum defaults to midnight of whenever the test runs.

I wonder if this is worth adding some sort of error condition to make it clearer? But let's get this fix in asap.

review: Approve
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Needs Fixing (continuous-integration)
Revision history for this message
PS Jenkins bot (ps-jenkins) :
review: Approve (continuous-integration)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'tests/unit_x11/tst_components/tst_datepicker.qml'
2--- tests/unit_x11/tst_components/tst_datepicker.qml 2013-12-19 10:18:45 +0000
3+++ tests/unit_x11/tst_components/tst_datepicker.qml 2014-01-07 15:15:39 +0000
4@@ -407,6 +407,7 @@
5 }
6
7 function test_1_changeDateToNextMonth() {
8+ picker.minimum = new Date(2013, 9, 1);
9 picker.date = new Date(2013, 09, 31);
10 picker.locale = Qt.locale("hu_HU")
11 wait(500);

Subscribers

People subscribed via source and target branches

to status/vote changes: