> > 747   + self.wait_select_single('QQuickItem', objectName='selection_panel0')
> 
> A proper error message in a ToolkitException is desirable here I think.

Ok, I'll add that.

> 
> The "new list items" section in the gallery prints "qml: Highlighting list
> item" when tapping, overlooked debugging? More importantly I don't see
> selection mode demonstrated at all.

That is Tim's playground, he used to update that part when I have an MR bringing new features to ListItem, that's the way he used to test the new features and eventually suggest API changes, extra API. That's why I don't have anything there. The print is an expected extra for the gallery.

> 
> I've used tests/resources/listitems/ListItemTest.qml for testing a bit,
> unfortunately it doesn't scroll so I'm not sure if I can see everything in
> there. At the bottom there's a very narrow item with a switch.

The whole view doesn't scroll, true. It's a bit crowded to be honest... It has a ListItem and a Flickable, testing attached behavior in both. Perhaps I should add a separate sample for select mode...

> 
> The test_listitem.ListItemTestCase.qml has "onPressAndHold:
> listView.ViewItems.selectMode = true", I'm thinking this should be available
> in the gallery and manual test case as well.

Right. As said, Tim used to test the API, perhaps you can also do an MR based on this and then we submit that. It's better if someone else tries also the API to make sure it's understandable and easy to use.

> 
> Visual observation: the animation from toggling select mode flickers
> extremely. Is this expected?
> 
> > 973   - flick(item, centerOf(item).x, centerOf(item).y, units.gu(20), 0);
> > 974   + swipe(item, centerOf(item).x, centerOf(item).y, units.gu(20), 0);
> 
> Why is this? Work-around? Something to document?

I think the swipe() function documents it... It is intentional, as we discussed in one of the standups last week, I have to move slower than the test function otherwise does, so the Repeater can create all the elements based on the model, otherwise the swipe is not reliable.

> 
> > 268   + * attached property. This property is attached to each parent item
> of the ListItem
> 
> I don't really understand the explanation and the example doesn't demonstrate
> what I think it says. There's no ListView here. The Flickable has the attached
> property but Column supposedly won't work. I would expect Column to be the
> parent and have the property. Aside from clarifying the wording I'd suggest
> two examples because of the special case.

No. ListItem's parents are the Column, and that will get the ViewItems attached property. Exception is the ListView, where the contentItem would be the one to have the attached property, but the ListItem detects it and attaches top ListView.

So, ViewItems is automatically attached to the ListItem's parent exception being when used as delegate of ListView, when will be attached to the ListView itself. So Column gets it automatically, and all you set in Column it will have effect to the ListItems in Column, but the one declared in Flickable won't work. It will not give error, but won't do anything. And unfortunately we cannot drive or detect whether the object is attached to a proper element, as the actual view is set up after being attached. In a sense it works same way as the ListView attached object, which has only effect when attached to the delegate of the ListView, but practically can be attached to any item.

I just realized that I have an error in the example code, I used ListItem instead of VirewItems. I have to fix that!