Code review comment for lp:~zsombi/ubuntu-ui-toolkit/00-remove-unity-actions

Revision history for this message
Cris Dywan (kalikiana) wrote :

What's with these uncommented test cases?

1602 + function test_unity_action_not_in_context() {
1603 +// verify(!contains(manager.globalContext.actions, unityAction, "Unity Action cannot be registered"));
1604 + }
1605 +
1606 + function test_cannot_add_unity_action_to_global_context() {
1607 + manager.globalContext.addAction(stockUnityAction);
1608 +// verify(!contains(manager.globalContext.actions, stockUnityAction, "Unity Action cannot be registered"));
1609 + }
1610 +
1611 + function test_cannot_add_unity_action_to_local_context() {
1612 + context1.addAction(stockUnityAction);
1613 +// verify(!contains(context1.actions, stockUnityAction, "Unity Action cannot be registered"));
1614 + }

review: Needs Fixing

« Back to merge proposal