Code review comment for lp:~zorba-coders/zorba/xml-in-json-indices

Revision history for this message
Ghislain Fourny (gislenius) wrote :

Hi Paul,

I formerly assessed the risk of reaching the limits of the int/long range for a position as highly unlikely, but I do have doubts about whether a negative number might go through. So I changed assert(false) to a proper processor exception. I also changed to const&.

« Back to merge proposal