Code review comment for lp:~zorba-coders/zorba/xml-in-json-indices
Revision history for this message
| Paul J. Lucas (paul-lucas) wrote | # |
© 2004
Canonical Ltd.
•
Terms of use
•
Data privacy
•
Contact Launchpad Support
•
Blog
•
Careers
•
System status
•
67d34a1
(Get the code!)
> Do the changes fulfil your expectations provided all tests pass?
No because you should catch by const& not by value. And is "assert(false)" really the only/best thing you can do? Is there any legitimate way the position can exceed the size of a long? If the answer is "yes," then you need to do something better.