Merge lp:~zorba-coders/zorba/util-jvm-ctest-fix into lp:zorba/util-jvm-module

Proposed by Chris Hillery
Status: Rejected
Rejected by: Chris Hillery
Proposed branch: lp:~zorba-coders/zorba/util-jvm-ctest-fix
Merge into: lp:zorba/util-jvm-module
Diff against target: 25 lines (+15/-0)
1 file modified
src/CMakeLists.txt (+15/-0)
To merge this branch: bzr merge lp:~zorba-coders/zorba/util-jvm-ctest-fix
Reviewer Review Type Date Requested Status
Chris Hillery Disapprove
Matthias Brantner Approve
Review via email: mp+107482@code.launchpad.net
To post a comment you must log in.
Revision history for this message
Matthias Brantner (matthias-brantner) :
review: Approve
Revision history for this message
Chris Hillery (ceejatec) :
review: Approve
Revision history for this message
Chris Hillery (ceejatec) wrote :

Actually, the changes here conflict with changes on the trunk. Since this proposal is from 7 months ago and as far as I know there are no outstanding problems with util-jvm, I'm going to assume this proposal is no longer desirable.

review: Disapprove

Unmerged revisions

13. By Chris Hillery

Force util-jvm library to build in same dir as libzorba.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'src/CMakeLists.txt'
2--- src/CMakeLists.txt 2012-05-22 00:15:11 +0000
3+++ src/CMakeLists.txt 2012-05-25 21:40:25 +0000
4@@ -34,6 +34,21 @@
5 # default lib directory.
6 ADD_LIBRARY(util-jvm SHARED util-jvm.cpp JavaVMSingleton.cpp)
7 TARGET_LINK_LIBRARIES(util-jvm "${JAVA_JVM_LIBRARY}" zorba_${ZORBA_STORE_NAME})
8+
9+# Need to create the util-jvm shared library in the same directory as
10+# libzorba. Since the libzorba target is created after modules are loaded,
11+# we have to just assume it here. We also have to assume that we are
12+# building as part of a Zorba build, but that actually is the only way
13+# this "module" works anyway.
14+# Shared libraries are considered RUNTIME targets on Win32
15+# platforms and LIBRARY targets elsewhere.
16+IF (WIN32)
17+ SET (target_type RUNTIME)
18+ELSE (WIN32)
19+ SET (target_type LIBRARY)
20+ENDIF (WIN32)
21+SET_TARGET_PROPERTIES(util-jvm PROPERTIES
22+ ${target_type}_OUTPUT_DIRECTORY "${CMAKE_BINARY_DIR}/src")
23 INSTALL(TARGETS util-jvm DESTINATION lib)
24
25 # MAC OS X only property

Subscribers

People subscribed via source and target branches

to all changes: