Merge lp:~zorba-coders/zorba/user-typed-atomic-item-is-encoded into lp:zorba

Proposed by Ghislain Fourny
Status: Merged
Approved by: Till Westmann
Approved revision: 10994
Merged at revision: 10999
Proposed branch: lp:~zorba-coders/zorba/user-typed-atomic-item-is-encoded
Merge into: lp:zorba
Diff against target: 12 lines (+2/-0)
1 file modified
src/store/naive/atomic_items.h (+2/-0)
To merge this branch: bzr merge lp:~zorba-coders/zorba/user-typed-atomic-item-is-encoded
Reviewer Review Type Date Requested Status
Till Westmann Approve
Matthias Brantner Approve
Review via email: mp+120577@code.launchpad.net

Commit message

Adds a method isEncoded to user-typed atomic items.

Description of the change

Adds a method isEncoded to user-typed atomic items.

To post a comment you must log in.
Revision history for this message
Zorba Build Bot (zorba-buildbot) wrote :

There are additional revisions which have not been approved in review. Please seek review and approval of these new revisions.

Revision history for this message
Zorba Build Bot (zorba-buildbot) wrote :
Revision history for this message
Matthias Brantner (matthias-brantner) :
review: Approve
Revision history for this message
Zorba Build Bot (zorba-buildbot) wrote :

Validation queue job user-typed-atomic-item-is-encoded-2012-08-21T15-51-00.261Z is finished. The final status was:

All tests succeeded!

Revision history for this message
Zorba Build Bot (zorba-buildbot) wrote :

Voting does not meet specified criteria. Required: Approve > 1, Disapprove < 1, Needs Fixing < 1, Pending < 1. Got: 1 Approve.

Revision history for this message
Till Westmann (tillw) :
review: Approve
Revision history for this message
Zorba Build Bot (zorba-buildbot) wrote :
Revision history for this message
Zorba Build Bot (zorba-buildbot) wrote :

Validation queue job user-typed-atomic-item-is-encoded-2012-08-24T23-40-58.618Z is finished. The final status was:

All tests succeeded!

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'src/store/naive/atomic_items.h'
2--- src/store/naive/atomic_items.h 2012-08-16 18:31:02 +0000
3+++ src/store/naive/atomic_items.h 2012-08-21 14:17:19 +0000
4@@ -154,6 +154,8 @@
5 void appendStringValue(zstring& buf) const { theBaseItem->appendStringValue(buf); }
6
7 const zstring& getString() const { return theBaseItem->getString(); }
8+
9+ bool isEncoded() const { return theBaseItem->isEncoded(); }
10
11 const char* getBase64BinaryValue(size_t& s) const
12 {

Subscribers

People subscribed via source and target branches