Merge lp:~zorba-coders/zorba/simple-collection-api-2 into lp:zorba

Proposed by Ghislain Fourny
Status: Merged
Approved by: Matthias Brantner
Approved revision: 10697
Merged at revision: 10698
Proposed branch: lp:~zorba-coders/zorba/simple-collection-api-2
Merge into: lp:zorba
Diff against target: 19 lines (+2/-2)
1 file modified
src/store/naive/collection.h (+2/-2)
To merge this branch: bzr merge lp:~zorba-coders/zorba/simple-collection-api-2
Reviewer Review Type Date Requested Status
Matthias Brantner Approve
Markos Zaharioudakis Approve
Review via email: mp+95926@code.launchpad.net

Commit message

Making two non-abstract functions in simplecollection API also non-virtual.

Description of the change

Making two non-abstract functions in simplecollection API also non-virtual.

To post a comment you must log in.
Revision history for this message
Ghislain Fourny (gislenius) wrote :

Markos: this addresses your comment in the simple-collection-api merge proposal.

Revision history for this message
Zorba Build Bot (zorba-buildbot) wrote :

No approved revision specified.

Revision history for this message
Markos Zaharioudakis (markos-za) :
review: Approve
Revision history for this message
Matthias Brantner (matthias-brantner) :
review: Approve
Revision history for this message
Zorba Build Bot (zorba-buildbot) wrote :
Revision history for this message
Zorba Build Bot (zorba-buildbot) wrote :

Validation queue job simple-collection-api-2-2012-03-05T19-58-05.31Z is finished. The final status was:

All tests succeeded!

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'src/store/naive/collection.h'
2--- src/store/naive/collection.h 2012-03-01 14:16:27 +0000
3+++ src/store/naive/collection.h 2012-03-05 15:56:19 +0000
4@@ -99,14 +99,14 @@
5 const store::Item* name,
6 std::vector<store::Index*>& indexes);
7
8- virtual void getIndexes(std::vector<store::Index*>& indexes);
9+ void getIndexes(std::vector<store::Index*>& indexes);
10
11 /**** Returns active integrity constraints referencing this collection ******/
12 static void getActiveICs(
13 const store::Item* name,
14 std::vector<store::IC*>& ics);
15
16- virtual void getActiveICs(std::vector<store::IC*>& ics);
17+ void getActiveICs(std::vector<store::IC*>& ics);
18
19 }; /* class Collection */
20

Subscribers

People subscribed via source and target branches