Merge lp:~zorba-coders/zorba/security-fix into lp:zorba/security-module

Proposed by Matthias Brantner
Status: Merged
Approved by: Chris Hillery
Approved revision: 22
Merged at revision: 22
Proposed branch: lp:~zorba-coders/zorba/security-fix
Merge into: lp:zorba/security-module
Diff against target: 12 lines (+0/-2)
1 file modified
src/hash.xq.src/hash.cpp (+0/-2)
To merge this branch: bzr merge lp:~zorba-coders/zorba/security-fix
Reviewer Review Type Date Requested Status
Chris Hillery Approve
Matthias Brantner Approve
Review via email: mp+83719@code.launchpad.net

Commit message

Removed debug output

Description of the change

Removed debug output

To post a comment you must log in.
Revision history for this message
Matthias Brantner (matthias-brantner) :
review: Approve
Revision history for this message
Zorba Build Bot (zorba-buildbot) wrote :
Revision history for this message
Zorba Build Bot (zorba-buildbot) wrote :

Validation queue job security-fix-2011-11-29T01-11-05.574Z is finished. The final status was:

All tests succeeded!

Revision history for this message
Zorba Build Bot (zorba-buildbot) wrote :

Voting does not meet specified criteria. Required: Approve > 1, Disapprove < 1. Got: 1 Approve, 1 Pending.

Revision history for this message
Chris Hillery (ceejatec) wrote :

Oh, goodness no, this is far too extensive and risky a change. Plus, you didn't say what bug number it was fixing, or update the Changelog.

(Sorry, still punchy on cold medication.)

review: Approve
Revision history for this message
Zorba Build Bot (zorba-buildbot) wrote :
Revision history for this message
Zorba Build Bot (zorba-buildbot) wrote :

Validation queue job security-fix-2011-11-29T01-49-41.109Z is finished. The final status was:

All tests succeeded!

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'src/hash.xq.src/hash.cpp'
2--- src/hash.xq.src/hash.cpp 2011-08-13 00:08:45 +0000
3+++ src/hash.xq.src/hash.cpp 2011-11-29 01:03:27 +0000
4@@ -97,8 +97,6 @@
5 std::stringstream lTmp;
6 lTmp.write(lRes, 20);
7
8- std::cout << "blub: " << lTmp.str() << std::endl;
9-
10 lHash = zorba::encoding::Base64::encode(lTmp);
11 } else {
12 lHash = md5(lText.str());

Subscribers

People subscribed via source and target branches

to all changes: