Merge lp:~zorba-coders/zorba/php_windows_fix into lp:zorba

Proposed by Juan Zacarias
Status: Merged
Merged at revision: 11667
Proposed branch: lp:~zorba-coders/zorba/php_windows_fix
Merge into: lp:zorba
Diff against target: 37 lines (+6/-3)
2 files modified
include/zorba/internal/diagnostic.h (+1/-3)
src/diagnostics/diagnostic.cpp (+5/-0)
To merge this branch: bzr merge lp:~zorba-coders/zorba/php_windows_fix
Reviewer Review Type Date Requested Status
Chris Hillery Approve
Juan Zacarias Approve
Review via email: mp+192253@code.launchpad.net

Commit message

Solved Linker error when building the php bindings.

To post a comment you must log in.
Revision history for this message
Juan Zacarias (juan457) :
review: Approve
Revision history for this message
Chris Hillery (ceejatec) :
review: Approve
Revision history for this message
Zorba Build Bot (zorba-buildbot) wrote :
Revision history for this message
Zorba Build Bot (zorba-buildbot) wrote :

Validation queue succeeded - proposal merged!

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'include/zorba/internal/diagnostic.h'
2--- include/zorba/internal/diagnostic.h 2013-09-13 21:42:43 +0000
3+++ include/zorba/internal/diagnostic.h 2013-10-22 21:42:17 +0000
4@@ -262,9 +262,7 @@
5 * @param j The second location.
6 * @return Returns \c true only if the two locations are not equal.
7 */
8-inline bool operator!=( location const &i, location const &j ) {
9- return !(i == j);
10-}
11+bool operator!=( location const &i, location const &j );
12
13 ///////////////////////////////////////////////////////////////////////////////
14
15
16=== modified file 'src/diagnostics/diagnostic.cpp'
17--- src/diagnostics/diagnostic.cpp 2013-09-13 21:43:08 +0000
18+++ src/diagnostics/diagnostic.cpp 2013-10-22 21:42:17 +0000
19@@ -66,6 +66,7 @@
20 && ztd::equals( q1.ns(), q2.ns() );
21 }
22
23+
24 bool operator==( QName const &q1, char const *q2 ) {
25 if ( q2 ) {
26 if ( *q2 == '{' ) {
27@@ -148,6 +149,10 @@
28 && i.column_end_ == j.column_end_;
29 }
30
31+bool operator!=( location const &i, location const &j ) {
32+ return !(i == j);
33+}
34+
35 parameters const parameters::empty;
36
37 #define case_123456789 \

Subscribers

People subscribed via source and target branches