Merge lp:~zorba-coders/zorba/new-base64-api into lp:zorba/security-module

Proposed by Paul J. Lucas
Status: Merged
Approved by: Paul J. Lucas
Approved revision: 32
Merged at revision: 30
Proposed branch: lp:~zorba-coders/zorba/new-base64-api
Merge into: lp:zorba/security-module
Diff against target: 31 lines (+4/-4)
2 files modified
src/hash.xq.src/hash.h (+2/-2)
src/hmac.xq.src/hmac.cpp (+2/-2)
To merge this branch: bzr merge lp:~zorba-coders/zorba/new-base64-api
Reviewer Review Type Date Requested Status
Matthias Brantner Approve
Paul J. Lucas Approve
Review via email: mp+177667@code.launchpad.net

Commit message

Corresponding changes for new Base64 public API.

Description of the change

Corresponding changes for new Base64 public API.

To post a comment you must log in.
31. By Paul J. Lucas

Fix.

32. By Paul J. Lucas

Fix.

Revision history for this message
Paul J. Lucas (paul-lucas) :
review: Approve
Revision history for this message
Matthias Brantner (matthias-brantner) :
review: Approve
Revision history for this message
Zorba Build Bot (zorba-buildbot) wrote :

Validation queue succeeded - proposal merged!

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'src/hash.xq.src/hash.h'
2--- src/hash.xq.src/hash.h 2013-06-21 20:55:00 +0000
3+++ src/hash.xq.src/hash.h 2013-07-30 18:49:28 +0000
4@@ -125,9 +125,9 @@
5 const char* lTmp = aMessage.getBase64BinaryValue(lLen);
6 if (aDecode)
7 {
8- String lTmpEncoded(lTmp, lLen);
9+ String lTmpEncoded;
10 // lTmpDecodedBuf is used to make sure lMsg is still alive during HMAC_Update
11- lTmpDecodedBuf = base64::decode(lTmpEncoded);
12+ base64::decode(lTmp, lLen, &lTmpDecodedBuf);
13 lTmp = lTmpDecodedBuf.c_str();
14 lLen = lTmpDecodedBuf.size();
15 }
16
17=== modified file 'src/hmac.xq.src/hmac.cpp'
18--- src/hmac.xq.src/hmac.cpp 2013-06-21 03:04:34 +0000
19+++ src/hmac.xq.src/hmac.cpp 2013-07-30 18:49:28 +0000
20@@ -218,9 +218,9 @@
21 const char* lMsg = lItem.getBase64BinaryValue(lSize);
22 if (lItem.isEncoded())
23 {
24- String lTmpEncoded(lMsg, lSize);
25+ String lTmpEncoded;
26 // lTmpDecodedBuf is used to make sure lMsg is still alive during HMAC_Update
27- lTmpDecodedBuf = base64::decode(lTmpEncoded);
28+ base64::decode(lMsg, lSize, &lTmpDecodedBuf);
29 lMsg = lTmpDecodedBuf.c_str();
30 lSize = lTmpDecodedBuf.size();
31 }

Subscribers

People subscribed via source and target branches

to all changes: