Merge lp:~zorba-coders/zorba/new-base64-api-archive into lp:zorba/archive-module

Proposed by Paul J. Lucas
Status: Merged
Approved by: Paul J. Lucas
Approved revision: 53
Merged at revision: 53
Proposed branch: lp:~zorba-coders/zorba/new-base64-api-archive
Merge into: lp:zorba/archive-module
Diff against target: 25 lines (+2/-6)
1 file modified
src/archive_module.xq.src/archive_module.cpp (+2/-6)
To merge this branch: bzr merge lp:~zorba-coders/zorba/new-base64-api-archive
Reviewer Review Type Date Requested Status
Matthias Brantner Approve
Paul J. Lucas Approve
Review via email: mp+177949@code.launchpad.net

Commit message

New Base64 API.

Description of the change

New Base64 API.

To post a comment you must log in.
Revision history for this message
Paul J. Lucas (paul-lucas) :
review: Approve
Revision history for this message
Matthias Brantner (matthias-brantner) :
review: Approve
Revision history for this message
Zorba Build Bot (zorba-buildbot) wrote :

Validation queue succeeded - proposal merged!

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'src/archive_module.xq.src/archive_module.cpp'
2--- src/archive_module.xq.src/archive_module.cpp 2013-07-29 19:24:56 +0000
3+++ src/archive_module.xq.src/archive_module.cpp 2013-07-31 22:08:28 +0000
4@@ -530,10 +530,7 @@
5
6 if (aFile.isEncoded())
7 {
8- zorba::String lEncoded(lBinValue, lResFileSize);
9- zorba::String lDecoded = zorba::base64::decode(lEncoded);
10- lStream->write(lDecoded.c_str(), lDecoded.length());
11- aResFileSize = lDecoded.size();
12+ aResFileSize = zorba::base64::decode(lBinValue, lResFileSize, *lStream);
13 }
14 else
15 {
16@@ -967,8 +964,7 @@
17
18 if (theArchiveItem.isEncoded())
19 {
20- zorba::String lEncoded(lData, lLen);
21- theDecodedData = base64::decode(lEncoded);
22+ base64::decode(lData, lLen, &theDecodedData);
23 lLen = theDecodedData.size();
24 lErr = archive_read_open_memory(theArchive,
25 const_cast<char*>(theDecodedData.c_str()), lLen);

Subscribers

People subscribed via source and target branches

to all changes: