Merge lp:~zorba-coders/zorba/markos-scratch into lp:zorba

Proposed by Markos Zaharioudakis
Status: Merged
Merged at revision: 11613
Proposed branch: lp:~zorba-coders/zorba/markos-scratch
Merge into: lp:zorba
Diff against target: 140 lines (+7/-44)
6 files modified
include/zorba/xmldatamanager.h (+0/-7)
src/api/xmldatamanagerimpl.cpp (+0/-28)
src/api/xmldatamanagerimpl.h (+0/-2)
src/context/static_context.cpp (+5/-5)
src/context/static_context.h (+1/-1)
src/zorbaserialization/archiver_consts.h (+1/-1)
To merge this branch: bzr merge lp:~zorba-coders/zorba/markos-scratch
Reviewer Review Type Date Requested Status
Markos Zaharioudakis Approve
Review via email: mp+184518@code.launchpad.net

Commit message

removed depracated fetchmethod from xmldatamanager

Description of the change

removed depracated fetchmethod from xmldatamanager

To post a comment you must log in.
Revision history for this message
Markos Zaharioudakis (markos-za) :
review: Approve
Revision history for this message
Zorba Build Bot (zorba-buildbot) wrote :

Validation queue starting for the following merge proposals:
https://code.launchpad.net/~zorba-coders/zorba/markos-scratch/+merge/184518

Progress dashboard at http://jenkins.lambda.nu/view/ValidationQueue

Revision history for this message
Zorba Build Bot (zorba-buildbot) wrote :

Validation queue succeeded - proposal merged!

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'include/zorba/xmldatamanager.h'
2--- include/zorba/xmldatamanager.h 2013-08-06 08:41:26 +0000
3+++ include/zorba/xmldatamanager.h 2013-09-09 08:53:25 +0000
4@@ -186,13 +186,6 @@
5 const String& aBaseURI,
6 ParseOptions& aOptions) const = 0;
7
8- /** \brief Fetches an resource refered to by the given URI.
9- *
10- * @deprecated this function has been replaced by StaticContext::fetch.
11- */
12- virtual Item
13- fetch(const String& aURI) const = 0;
14-
15 /** \brief Register a DiagnosticHandler to which errors occuring during the
16 * management of documents and collections are reported.
17 *
18
19=== modified file 'src/api/xmldatamanagerimpl.cpp'
20--- src/api/xmldatamanagerimpl.cpp 2013-08-06 08:41:26 +0000
21+++ src/api/xmldatamanagerimpl.cpp 2013-09-09 08:53:25 +0000
22@@ -110,7 +110,6 @@
23 Zorba_CompilerHints_t lHints;
24 std::ostringstream lProlog;
25 lProlog
26- << "import module namespace d = '" << static_context::ZORBA_FETCH_FN_NS << "';"
27 << "import module namespace x = '" << static_context::ZORBA_XML_FN_NS << "';"
28 << "import schema namespace opt = '" << static_context::ZORBA_XML_FN_OPTIONS_NS << "';";
29
30@@ -355,33 +354,6 @@
31 /*******************************************************************************
32
33 ********************************************************************************/
34-Item XmlDataManagerImpl::fetch(const String& aURI) const
35-{
36- ZORBA_DM_TRY
37- {
38- Item lQName = theFactory->createQName(static_context::ZORBA_FETCH_FN_NS,
39- "content");
40-
41- // create a streamable string item
42- std::vector<ItemSequence_t> lArgs;
43- lArgs.push_back(
44- new SingletonItemSequence(theFactory->createString(aURI)));
45-
46- ItemSequence_t lSeq = theContext->invoke(lQName, lArgs);
47- Iterator_t lIter = lSeq->getIterator();
48- lIter->open();
49- Item lRes;
50- lIter->next(lRes);
51- return lRes;
52- }
53- ZORBA_DM_CATCH
54- return 0;
55-}
56-
57-
58-/*******************************************************************************
59-
60-********************************************************************************/
61 void XmlDataManagerImpl::registerDiagnosticHandler(DiagnosticHandler* aDiagnosticHandler)
62 {
63 theContext = new StaticContextImpl(aDiagnosticHandler);
64
65=== modified file 'src/api/xmldatamanagerimpl.h'
66--- src/api/xmldatamanagerimpl.h 2013-08-06 08:41:26 +0000
67+++ src/api/xmldatamanagerimpl.h 2013-09-09 08:53:25 +0000
68@@ -85,8 +85,6 @@
69 const String& aBaseURI,
70 ParseOptions& aOptions) const;
71
72- Item fetch(const String& aURI) const;
73-
74 void registerDiagnosticHandler(DiagnosticHandler* aDiagnosticHandler);
75
76 #ifndef ZORBA_NO_FULL_TEXT
77
78=== modified file 'src/context/static_context.cpp'
79--- src/context/static_context.cpp 2013-09-02 20:43:22 +0000
80+++ src/context/static_context.cpp 2013-09-09 08:53:25 +0000
81@@ -263,7 +263,7 @@
82 ar & lURI;
83 ar.set_is_temp_field(false);
84 ar & dyn_loaded_module;
85- ar & sctx;
86+ ar & theSctx;
87 }
88 else
89 {
90@@ -275,12 +275,12 @@
91 ar & lURI;
92 ar.set_is_temp_field(false);
93 ar & dyn_loaded_module;
94- ar & sctx;
95+ ar & theSctx;
96
97 if (dyn_loaded_module)
98 {
99- ZORBA_ASSERT(sctx);
100- module = GENV_DYNAMIC_LOADER->getExternalModule(lURI, *sctx);
101+ ZORBA_ASSERT(theSctx);
102+ module = GENV_DYNAMIC_LOADER->getExternalModule(lURI, *theSctx);
103
104 // no way to get the module
105 if (!module)
106@@ -2951,7 +2951,7 @@
107 ctx_module_t modinfo;
108 modinfo.module = aModule;
109 modinfo.dyn_loaded_module = aDynamicallyLoaded;
110- modinfo.sctx = this;
111+ modinfo.theSctx = this;
112
113 if (!theExternalModulesMap->insert(uri, modinfo))
114 {
115
116=== modified file 'src/context/static_context.h'
117--- src/context/static_context.h 2013-08-24 23:38:45 +0000
118+++ src/context/static_context.h 2013-09-09 08:53:25 +0000
119@@ -473,7 +473,7 @@
120 {
121 ExternalModule * module;
122 bool dyn_loaded_module;
123- static_context * sctx;
124+ static_context * theSctx;
125
126 public:
127 SERIALIZABLE_CLASS(ctx_module_t)
128
129=== modified file 'src/zorbaserialization/archiver_consts.h'
130--- src/zorbaserialization/archiver_consts.h 2013-08-16 13:00:06 +0000
131+++ src/zorbaserialization/archiver_consts.h 2013-09-09 08:53:25 +0000
132@@ -36,7 +36,7 @@
133 serialized when a pointer to it was encountered. In this case, during
134 deserialization, the archiver will allocate the obj on the heap and fill-in
135 its data members. If the kind is NORMAL, then the obj was serialized when the
136- objitself was encountered (e.g., the object was an embedded data member of
137+ object itself was encountered (e.g., the object was an embedded data member of
138 another obj, or was residing on the program stack). In this case, during
139 deserialization, the object exists already (in an uninitialized state) and a
140 reference to it is given to the archiver, which will fill-in the obj's data.

Subscribers

People subscribed via source and target branches