Merge lp:~zorba-coders/zorba/markos-scratch into lp:zorba

Proposed by Markos Zaharioudakis
Status: Merged
Approved by: Markos Zaharioudakis
Approved revision: 11156
Merged at revision: 11526
Proposed branch: lp:~zorba-coders/zorba/markos-scratch
Merge into: lp:zorba
Diff against target: 114 lines (+34/-22)
5 files modified
src/compiler/translator/translator.cpp (+7/-1)
src/store/naive/loader_fast.cpp (+24/-19)
test/fots/CMakeLists.txt (+0/-1)
test/rbkt/ExpQueryResults/zorba/jsoniq/keys_05.xml.res (+1/-1)
test/rbkt/Queries/zorba/jsoniq/keys_05.xq (+2/-0)
To merge this branch: bzr merge lp:~zorba-coders/zorba/markos-scratch
Reviewer Review Type Date Requested Status
Markos Zaharioudakis Approve
Review via email: mp+170288@code.launchpad.net

Commit message

Description of the change

To post a comment you must log in.
Revision history for this message
Markos Zaharioudakis (markos-za) :
review: Approve
Revision history for this message
Zorba Build Bot (zorba-buildbot) wrote :
Revision history for this message
Zorba Build Bot (zorba-buildbot) wrote :

The attempt to merge lp:~zorba-coders/zorba/markos-scratch into lp:zorba failed. Below is the output from the failed tests.

CMake Error at /home/ceej/zo/testing/zorbatest/tester/TarmacLander.cmake:281 (message):
  Validation queue job markos-scratch-2013-06-19T10-08-56.951Z is finished.
  The final status was:

  1 tests did not succeed - changes not commited.

Error in read script: /home/ceej/zo/testing/zorbatest/tester/TarmacLander.cmake

11156. By Markos Zaharioudakis

fixed bug #1188304

Revision history for this message
Zorba Build Bot (zorba-buildbot) wrote :
Revision history for this message
Zorba Build Bot (zorba-buildbot) wrote :

Validation queue job markos-scratch-2013-06-19T11-02-01.275Z is finished. The final status was:

All tests succeeded!

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'src/compiler/translator/translator.cpp'
2--- src/compiler/translator/translator.cpp 2013-06-18 11:51:57 +0000
3+++ src/compiler/translator/translator.cpp 2013-06-19 10:57:29 +0000
4@@ -403,7 +403,7 @@
5 theImportedModules :
6 --------------------
7 A set containing the target namespace uris of the modules directly imported
8- by this module. Used to check that the same module is not imported twice by
9+ by this module. Used to check that the same module is not imported twice by
10 this module.
11
12 theModuleNamespace :
13@@ -3378,6 +3378,12 @@
14 std::vector<zstring> compURIs;
15 if (atlist == NULL || atlist->size() == 0)
16 {
17+ if (theSctx->xquery_version() >= StaticContextConsts::xquery_version_3_0 &&
18+ targetNS == theModuleNamespace)
19+ {
20+ return;
21+ }
22+
23 // Note the use of versioned_uri() here, so that the namespace with any
24 // version fragment will be passed through to the mappers.
25 theSctx->get_component_uris(modVer.versioned_uri(),
26
27=== modified file 'src/store/naive/loader_fast.cpp'
28--- src/store/naive/loader_fast.cpp 2013-04-08 22:59:58 +0000
29+++ src/store/naive/loader_fast.cpp 2013-06-19 10:57:29 +0000
30@@ -147,31 +147,36 @@
31 } // if
32
33 XmlLoader *const loader = static_cast<XmlLoader*>( ctx );
34- switch ( error->level )
35+
36+ xmlErrorLevel errorLevel = error->level;
37+
38+ if (error->code == XML_WAR_NS_URI)
39+ {
40+ errorLevel = XML_ERR_WARNING;
41+ }
42+
43+ switch (errorLevel)
44 {
45 case XML_ERR_ERROR:
46- case XML_ERR_FATAL: {
47- XQueryException *const xe = NEW_XQUERY_EXCEPTION(
48- zerr::ZSTR0021_LOADER_PARSING_ERROR,
49- ERROR_PARAMS(
50- error->file, error->line, error->int2 /* column */,
51- libxml_dict_key_4, error_str1_5, error_str2_6, error_str3_7,
52- error_int1_8, error_message_9
53- )
54- );
55+ case XML_ERR_FATAL:
56+ {
57+ XQueryException *const xe =
58+ NEW_XQUERY_EXCEPTION(zerr::ZSTR0021_LOADER_PARSING_ERROR,
59+ ERROR_PARAMS(error->file, error->line, error->int2 /* column */,
60+ libxml_dict_key_4, error_str1_5, error_str2_6, error_str3_7,
61+ error_int1_8, error_message_9));
62+
63 xe->set_data( error->file, error->line, error->int2 /* column */ );
64 loader->theXQueryDiagnostics->add_error( xe );
65 break;
66 }
67- case XML_ERR_WARNING: {
68- XQueryWarning *const xw = NEW_XQUERY_WARNING(
69- zwarn::ZWST0007_LOADER_PARSING_WARNING,
70- WARN_PARAMS(
71- error->file, error->line, error->int2 /* column */,
72- libxml_dict_key_4, error_str1_5, error_str2_6, error_str3_7,
73- error_int1_8, error_message_9
74- )
75- );
76+ case XML_ERR_WARNING:
77+ {
78+ XQueryWarning *const xw =
79+ NEW_XQUERY_WARNING(zwarn::ZWST0007_LOADER_PARSING_WARNING,
80+ WARN_PARAMS(error->file, error->line, error->int2 /* column */,
81+ libxml_dict_key_4, error_str1_5, error_str2_6, error_str3_7,
82+ error_int1_8, error_message_9));
83 xw->set_data( error->file, error->line, error->int2 /* column */ );
84 loader->theXQueryDiagnostics->add_warning( xw );
85 break;
86
87=== modified file 'test/fots/CMakeLists.txt'
88--- test/fots/CMakeLists.txt 2013-06-18 09:10:28 +0000
89+++ test/fots/CMakeLists.txt 2013-06-19 10:57:29 +0000
90@@ -264,7 +264,6 @@
91 EXPECTED_FOTS_FAILURE (prod-InstanceofExpr instanceof139 1110217)
92 EXPECTED_FOTS_FAILURE (prod-InstanceofExpr instanceof140 1110217)
93 EXPECTED_FOTS_FAILURE (prod-InstanceofExpr cbcl-instance-of-001 1110217)
94-EXPECTED_FOTS_FAILURE (prod-DirElemContent.namespace K2-DirectConElemNamespace-76 1188304)
95 EXPECTED_FOTS_FAILURE (prod-EQName eqname-017 1188240)
96 EXPECTED_FOTS_FAILURE (prod-Literal K2-Literals-7 1188234)
97 EXPECTED_FOTS_FAILURE (prod-Literal K2-Literals-20 1188231)
98
99=== modified file 'test/rbkt/ExpQueryResults/zorba/jsoniq/keys_05.xml.res'
100--- test/rbkt/ExpQueryResults/zorba/jsoniq/keys_05.xml.res 2013-06-18 18:55:33 +0000
101+++ test/rbkt/ExpQueryResults/zorba/jsoniq/keys_05.xml.res 2013-06-19 10:57:29 +0000
102@@ -1,1 +1,1 @@
103-foo1 foo2
104+foo1 foo2 foo1 foo2
105
106=== modified file 'test/rbkt/Queries/zorba/jsoniq/keys_05.xq'
107--- test/rbkt/Queries/zorba/jsoniq/keys_05.xq 2013-06-18 18:55:33 +0000
108+++ test/rbkt/Queries/zorba/jsoniq/keys_05.xq 2013-06-19 10:57:29 +0000
109@@ -1,3 +1,5 @@
110+
111+for $j in (1, 2)
112 let $a :=
113 for $i in 1 to 10
114 return { if ($i mod 2 eq 0) then "foo2" else "foo1" : "bar" || $i }

Subscribers

People subscribed via source and target branches