Merge lp:~zorba-coders/zorba/markos-scratch into lp:zorba

Proposed by Markos Zaharioudakis
Status: Merged
Approved by: Markos Zaharioudakis
Approved revision: 11015
Merged at revision: 11243
Proposed branch: lp:~zorba-coders/zorba/markos-scratch
Merge into: lp:zorba
Diff against target: 22 lines (+1/-3)
1 file modified
src/runtime/json/jsoniq_functions_impl.cpp (+1/-3)
To merge this branch: bzr merge lp:~zorba-coders/zorba/markos-scratch
Reviewer Review Type Date Requested Status
Markos Zaharioudakis Approve
Review via email: mp+148888@code.launchpad.net

Commit message

optimized ref counting in JSONObjectNamesIterator::nextImpl()

Description of the change

optimized ref counting in JSONObjectNamesIterator::nextImpl()

To post a comment you must log in.
Revision history for this message
Markos Zaharioudakis (markos-za) :
review: Approve
Revision history for this message
Zorba Build Bot (zorba-buildbot) wrote :
Revision history for this message
Zorba Build Bot (zorba-buildbot) wrote :

Validation queue job markos-scratch-2013-02-16T16-53-58.353Z is finished. The final status was:

All tests succeeded!

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'src/runtime/json/jsoniq_functions_impl.cpp'
2--- src/runtime/json/jsoniq_functions_impl.cpp 2013-02-12 03:55:18 +0000
3+++ src/runtime/json/jsoniq_functions_impl.cpp 2013-02-16 16:44:28 +0000
4@@ -884,7 +884,6 @@
5 PlanState& planState) const
6 {
7 store::Item_t input;
8- store::Item_t key;
9
10 JSONObjectNamesIteratorState* state;
11 DEFAULT_STACK_INIT(JSONObjectNamesIteratorState, state, planState);
12@@ -894,9 +893,8 @@
13 state->theNames = input->getObjectKeys();
14 state->theNames->open();
15
16- while (state->theNames->next(key))
17+ while (state->theNames->next(result))
18 {
19- result = key;
20 STACK_PUSH (true, state);
21 }
22 state->theNames = NULL;

Subscribers

People subscribed via source and target branches