Merge lp:~zorba-coders/zorba/install_mysql_update into lp:zorba/jdbc-module

Proposed by Chris Hillery
Status: Merged
Approved by: Chris Hillery
Approved revision: 56
Merged at revision: 57
Proposed branch: lp:~zorba-coders/zorba/install_mysql_update
Merge into: lp:zorba/jdbc-module
Diff against target: 70 lines (+14/-8)
1 file modified
setup/mysql-setup.sh (+14/-8)
To merge this branch: bzr merge lp:~zorba-coders/zorba/install_mysql_update
Reviewer Review Type Date Requested Status
Cezar Andrei Approve
Chris Hillery Approve
Review via email: mp+171032@code.launchpad.net

Commit message

Update test-setup script to MySQL 5.6; don't download Connector jar; cleanup.

To post a comment you must log in.
Revision history for this message
Chris Hillery (ceejatec) :
review: Approve
Revision history for this message
Cezar Andrei (cezar-andrei) :
review: Approve
Revision history for this message
Zorba Build Bot (zorba-buildbot) wrote :

Validation queue starting for the following merge proposals:
https://code.launchpad.net/~zorba-coders/zorba/install_mysql_update/+merge/171032

Progress dashboard at http://jenkins.lambda.nu/view/ValidationQueue

Revision history for this message
Zorba Build Bot (zorba-buildbot) wrote :

Voting criteria failed for the following merge proposals:

https://code.launchpad.net/~zorba-coders/zorba/install_mysql_update/+merge/171032 :
Votes: {'Approve': 2, 'Needs commit message': 1}

Revision history for this message
Zorba Build Bot (zorba-buildbot) wrote :

Validation queue result for https://code.launchpad.net/~zorba-coders/zorba/install_mysql_update/+merge/171032

Stage "CommitZorba" failed.

Check console output at http://jenkins.lambda.nu/job/CommitZorba/10/console to view the results.

Revision history for this message
Zorba Build Bot (zorba-buildbot) wrote :

Validation queue starting for the following merge proposals:
https://code.launchpad.net/~zorba-coders/zorba/install_mysql_update/+merge/171032

Progress dashboard at http://jenkins.lambda.nu/view/ValidationQueue

Revision history for this message
Zorba Build Bot (zorba-buildbot) wrote :

Validation queue succeeded - proposal merged!

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'setup/mysql-setup.sh'
2--- setup/mysql-setup.sh 2013-01-03 10:58:09 +0000
3+++ setup/mysql-setup.sh 2013-06-24 08:18:29 +0000
4@@ -1,7 +1,7 @@
5 #!/bin/bash
6
7 # Default location to dump stuff and create databases
8-WORKDIR=~/jdbc-module-mysql
9+WORKDIR=`pwd`/jdbc-module-mysql
10
11 # MySQL'd "datadir"
12 DATADIR=${WORKDIR}/datadir
13@@ -9,6 +9,10 @@
14 # Location for the logs
15 LOGDIR=${WORKDIR}/log
16
17+# Filename for download
18+MYSQL_PKG=mysql-5.6.12-linux-glibc2.5-x86_64
19+MYSQL_TGZ=${MYSQL_PKG}.tar.gz
20+
21 while getopts distchw: opt
22 do
23 case "$opt" in
24@@ -19,17 +23,17 @@
25 d)
26 echo "Download"
27 mkdir -p $WORKDIR
28+ (
29 cd $WORKDIR
30- wget http://cdn.mysql.com/Downloads/MySQL-5.5/mysql-5.5.28-linux2.6-x86_64.tar.gz
31- wget http://cdn.mysql.com/Downloads/Connector-J/mysql-connector-java-5.1.22.tar.gz
32+ wget -c http://cdn.mysql.com/Downloads/MySQL-5.6/$MYSQL_TGZ
33+ )
34 ;;
35 i)
36 echo "Install"
37 (
38 cd $WORKDIR
39- tar -xvzf mysql-5.5.28-linux2.6-x86_64.tar.gz
40- tar -xvzf mysql-connector-java-5.1.22.tar.gz
41- mv mysql-5.5.28-linux2.6-x86_64 mysql
42+ tar -xvzf $MYSQL_TGZ
43+ mv $MYSQL_PKG mysql
44 sudo apt-get install libaio1
45 mkdir -p $DATADIR $LOGDIR $DATADIR/innodb_log
46 ./mysql/scripts/mysql_install_db --user=$USER --datadir=$DATADIR --basedir=./mysql --no-defaults
47@@ -39,9 +43,10 @@
48 ;;
49 s)
50 echo "Start"
51+ (
52 cd $WORKDIR/mysql
53 ./bin/mysqld_safe --defaults-file=$DATADIR/my.cnf --user=$USER --pid-file=$DATADIR/mysql_rq.pid --datadir=$DATADIR --log-error=$LOGDIR/log.err &
54- cd ..
55+ )
56 ;;
57 t)
58 echo "Stop"
59@@ -49,9 +54,10 @@
60 ;;
61 c)
62 echo "Clean everything"
63+ (
64 cd $WORKDIR
65 rm -fR ./mysql
66- rm -fR ./mysql-connector-java-5.1.22
67+ )
68 ;;
69 h)
70 echo "usage: $0 [-distcvh] [-w path]"

Subscribers

People subscribed via source and target branches

to all changes: