Code review comment for lp:~zorba-coders/zorba/identifiers

>
> The function returns the empty sequence if the node
> that is referenced was deleted.
> =>
> The function returns the empty sequence if the node
> that is referenced does not exist (e.g. because it was deleted or the
> temporary node is not available anymore)
>

I wouldn't add the "(e.g. because ....)" part. After all, a temporary node becomes not available by being deleted. So, the phrase does not really add any additional info.

> zerr::ZAPI0028
> =>
> zerr:ZAPI0028
>
> Can any of the functions return ZAPI0029? If so, it's not documented. Same for
> ZAPI0030.
>

I am not sure, but these 2 errors are being used just for internal sanity checks. If so, they should be removed from the diagnostics list (use ZORBA_ASSERT() instead).

>
> What is the following change in node_items.cpp for?
> 513 - theTypesMap = new
> NodeTypeMap(source->theTypesMap->object_count(), false);
> 514 + theTypesMap = new NodeTypeMap(source->theTypesMap->size(),
> false);
>

I made this change because I changed theNodeToReferencesMap to be a hashmap (instead of std::map), and in doing so, I renamed some of the HashMap methods to better match the std::map methods.