Zorba

Code review comment for lp:~zorba-coders/zorba/get-namespace-bindings

  1. get-namespace-bindings
  2. Merge into trunk
Revision history for this message
Matthias Brantner (matthias-brantner) wrote :

> Regarding vector vs. map, after thinking about it a bit, I agree with you that
> map<> would be at least a bit better user experience. However,
> ItemFactory::createElementNode() takes a vector<pair<>> already, and that
> can't be changed. I think probably it's best that getNamespaceBindings() be
> consistent with that API.
Fair enough.

>
> In fact, probably createElementNode() should be changed to use the same
> typedef as getNamespaceBindings(). Should I move the typedef for NsBindings
> into store_consts.h?
No, I don't think so. Because the internal NsBindings uses zstring (not zorba::String)

« Back to merge proposal