I've changed to use zorba::store::StoreConsts::NsScoping.
Regarding vector vs. map, after thinking about it a bit, I agree with you that map<> would be at least a bit better user experience. However, ItemFactory::createElementNode() takes a vector<pair<>> already, and that can't be changed. I think probably it's best that getNamespaceBindings() be consistent with that API.
In fact, probably createElementNode() should be changed to use the same typedef as getNamespaceBindings(). Should I move the typedef for NsBindings into store_consts.h?
I've changed to use zorba:: store:: StoreConsts: :NsScoping.
Regarding vector vs. map, after thinking about it a bit, I agree with you that map<> would be at least a bit better user experience. However, ItemFactory: :createElementN ode() takes a vector<pair<>> already, and that can't be changed. I think probably it's best that getNamespaceBin dings() be consistent with that API.
In fact, probably createElementNode() should be changed to use the same typedef as getNamespaceBin dings() . Should I move the typedef for NsBindings into store_consts.h?