Merge lp:~zorba-coders/zorba/general-tree-ids into lp:zorba

Proposed by Ghislain Fourny
Status: Merged
Approved by: Markos Zaharioudakis
Approved revision: 10748
Merged at revision: 10846
Proposed branch: lp:~zorba-coders/zorba/general-tree-ids
Merge into: lp:zorba
Diff against target: 25 lines (+2/-2)
2 files modified
test/rbkt/Queries/zorba/nodes/position_4.xq (+1/-1)
test/rbkt/Queries/zorba/nodes/position_4_parsed.xq (+1/-1)
To merge this branch: bzr merge lp:~zorba-coders/zorba/general-tree-ids
Reviewer Review Type Date Requested Status
Markos Zaharioudakis Approve
Matthias Brantner Approve
Review via email: mp+105222@code.launchpad.net

This proposal supersedes a proposal from 2012-04-03.

Commit message

Allowing general tree IDs (containing hexadecimal digits and dash) in structural URIs (test).

Description of the change

Allowing general tree IDs in structural URIs (test).

To post a comment you must log in.
Revision history for this message
Markos Zaharioudakis (markos-za) : Posted in a previous version of this proposal
review: Approve
Revision history for this message
Matthias Brantner (matthias-brantner) : Posted in a previous version of this proposal
review: Approve
Revision history for this message
Zorba Build Bot (zorba-buildbot) wrote : Posted in a previous version of this proposal
Revision history for this message
Zorba Build Bot (zorba-buildbot) wrote : Posted in a previous version of this proposal

The attempt to merge lp:~zorba-coders/zorba/general-tree-ids into lp:zorba failed. Below is the output from the failed tests.

CMake Error at /home/ceej/zo/testing/zorbatest/tester/TarmacLander.cmake:274 (message):
  Validation queue job general-tree-ids-2012-04-27T19-03-49.707Z is finished.
  The final status was:

  2 tests did not succeed - changes not commited.

Error in read script: /home/ceej/zo/testing/zorbatest/tester/TarmacLander.cmake

Revision history for this message
Zorba Build Bot (zorba-buildbot) wrote : Posted in a previous version of this proposal
Revision history for this message
Zorba Build Bot (zorba-buildbot) wrote : Posted in a previous version of this proposal

The attempt to merge lp:~zorba-coders/zorba/general-tree-ids into lp:zorba failed. Below is the output from the failed tests.

CMake Error at /home/ceej/zo/testing/zorbatest/tester/TarmacLander.cmake:274 (message):
  Validation queue job general-tree-ids-2012-05-04T14-25-58.202Z is finished.
  The final status was:

  2 tests did not succeed - changes not commited.

Error in read script: /home/ceej/zo/testing/zorbatest/tester/TarmacLander.cmake

Revision history for this message
Zorba Build Bot (zorba-buildbot) wrote :
Revision history for this message
Zorba Build Bot (zorba-buildbot) wrote :

Validation queue job general-tree-ids-2012-05-09T15-15-01.982Z is finished. The final status was:

All tests succeeded!

Revision history for this message
Zorba Build Bot (zorba-buildbot) wrote :

Voting does not meet specified criteria. Required: Approve > 1, Disapprove < 1, Needs Fixing < 1, Pending < 1. Got: 3 Pending.

Revision history for this message
Matthias Brantner (matthias-brantner) :
review: Approve
Revision history for this message
Markos Zaharioudakis (markos-za) :
review: Approve
Revision history for this message
Zorba Build Bot (zorba-buildbot) wrote :
Revision history for this message
Zorba Build Bot (zorba-buildbot) wrote :

Validation queue job general-tree-ids-2012-05-16T19-14-17.47Z is finished. The final status was:

All tests succeeded!

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'test/rbkt/Queries/zorba/nodes/position_4.xq'
2--- test/rbkt/Queries/zorba/nodes/position_4.xq 2012-05-03 12:31:51 +0000
3+++ test/rbkt/Queries/zorba/nodes/position_4.xq 2012-05-09 15:13:22 +0000
4@@ -2,7 +2,7 @@
5
6 declare function local:get-ordpath($struct)
7 {
8-replace($struct,'^zorba:\d*\.\d*\.\d*\.','np:')
9+replace($struct,'^zorba:\d*\.[0-9a-fA-F\-]*\.\d*\.','np:')
10 };
11
12 declare function local:test-generated-ordpath($testa,$testb)
13
14=== modified file 'test/rbkt/Queries/zorba/nodes/position_4_parsed.xq'
15--- test/rbkt/Queries/zorba/nodes/position_4_parsed.xq 2012-05-03 12:31:51 +0000
16+++ test/rbkt/Queries/zorba/nodes/position_4_parsed.xq 2012-05-09 15:13:22 +0000
17@@ -2,7 +2,7 @@
18
19 declare function local:get-ordpath($struct)
20 {
21-replace($struct,'^zorba:\d*\.\d*\.\d*\.','np:')
22+replace($struct,'^zorba:\d*\.[0-9a-fA-F\-]*\.\d*\.','np:')
23 };
24
25 declare function local:test-generated-ordpath($testa,$testb)

Subscribers

People subscribed via source and target branches