Code review comment for lp:~zorba-coders/zorba/fn_envvars

- There seems to be a merge conflict.
- The stream stored in the state must be deleted using the streamReleaser
- The lErrorMessage stream is passed as parameter but the errors only take one parameter.
- The LoadProperties are not used anywhere
- The following can be simplified
  if(getline(*state->theStream, streamLine))
  {
    do
    {
      STACK_PUSH(GENV_ITEMFACTORY->createString(result, streamLine), state);
    }
    while (getline(*state->theStream, streamLine));
  }
  else
    STACK_PUSH(false, state);

=>
    while (getline(*state->theStream, streamLine))
    {
      STACK_PUSH(GENV_ITEMFACTORY->createString(result, streamLine), state);
    }

review: Needs Fixing

« Back to merge proposal