Code review comment for lp:~zorba-coders/zorba/fn_envvars

> > - the unparsed-text-lines function doesn't really stream because it
> > materializes all the lines in a vector before returning them. Instead, the
> > iterator should keep the istream in it's state and return the lines as they
> > are parsed from the stream.
> Just one question about this, the Item returned by the function for each line
> should be a Stream then?
No, I don't think that's necessary. A line should be relatively short. It would probably be overhead to stream a single line.

« Back to merge proposal