Code review comment for lp:~zorba-coders/zorba/fix_xqdoc_schema_import_prefix

Revision history for this message
Sorin Marian Nasoi (sorin.marian.nasoi) wrote :

> > > Does this also work for schema imports without a prefix?
> > Are you referring to:
> > import schema default element namespace "SOMETHING"; ?
> >
> > The answer would be no, the current changes are not tested for this because
> we
> > have no modules at this point using this kind of schema imports.
> >
> > The xqdoc printer would have to be updated and also the xqdoc2html converter
> > in order to support this.
> >
> > IMHO this should not be a show stopper for these changes: If you agree
> please
> > create a lp bug for me for this feature and approve this merge.
> Yes, that's what I mean. It looks like the xqdoc visitor could crash with this
> change. That's why I think the branch shouldn't be merged before it's tested.
Nope, I disagree: this merge does not introduce the problem you mentioned because it was already there :)

All this change did was to make you and then me aware that we have a problem if one uses a schema import without a prefix.

So my suggestion is: please open a bug for this issue and approve this merge.

« Back to merge proposal