Code review comment for lp:~zorba-coders/zorba/fix_xqdoc_schema_import_prefix
Revision history for this message
| Matthias Brantner (matthias-brantner) wrote | # |
© 2004
Canonical Ltd.
•
Terms of use
•
Data privacy
•
Contact Launchpad Support
•
Blog
•
Careers
•
System status
•
67d34a1
(Get the code!)
> > Does this also work for schema imports without a prefix?
> Are you referring to:
> import schema default element namespace "SOMETHING"; ?
>
> The answer would be no, the current changes are not tested for this because we
> have no modules at this point using this kind of schema imports.
>
> The xqdoc printer would have to be updated and also the xqdoc2html converter
> in order to support this.
>
> IMHO this should not be a show stopper for these changes: If you agree please
> create a lp bug for me for this feature and approve this merge.
Yes, that's what I mean. It looks like the xqdoc visitor could crash with this change. That's why I think the branch shouldn't be merged before it's tested.