Merge lp:~zorba-coders/zorba/fix_bug_1167641 into lp:zorba

Proposed by Sorin Marian Nasoi
Status: Merged
Approved by: Chris Hillery
Approved revision: 11404
Merged at revision: 11461
Proposed branch: lp:~zorba-coders/zorba/fix_bug_1167641
Merge into: lp:zorba
Diff against target: 69 lines (+14/-7)
3 files modified
test/fots/CMakeLists.txt (+1/-1)
test/fots_driver/environment.xq (+10/-5)
test/fots_driver/fots-driver.xq (+3/-1)
To merge this branch: bzr merge lp:~zorba-coders/zorba/fix_bug_1167641
Reviewer Review Type Date Requested Status
Chris Hillery Approve
Sorin Marian Nasoi Approve
Review via email: mp+164540@code.launchpad.net

Commit message

FOTS driver fox for lp:1167641.

To post a comment you must log in.
Revision history for this message
Sorin Marian Nasoi (sorin.marian.nasoi) :
review: Approve
Revision history for this message
Zorba Build Bot (zorba-buildbot) wrote :
Revision history for this message
Zorba Build Bot (zorba-buildbot) wrote :

Validation queue job fix_bug_1167641-2013-05-17T21-07-53.798Z is finished. The final status was:

All tests succeeded!

Revision history for this message
Zorba Build Bot (zorba-buildbot) wrote :

Voting does not meet specified criteria. Required: Approve > 1, Disapprove < 1, Needs Fixing < 1, Pending < 1, Needs Information < 1, Resubmit < 1. Got: 1 Approve.

Revision history for this message
Chris Hillery (ceejatec) :
review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'test/fots/CMakeLists.txt'
2--- test/fots/CMakeLists.txt 2013-05-16 22:26:07 +0000
3+++ test/fots/CMakeLists.txt 2013-05-17 21:06:26 +0000
4@@ -169,7 +169,7 @@
5 EXPECTED_FOTS_FAILURE (fn-format-number numberformat60q 1167609)
6 EXPECTED_FOTS_FAILURE (fn-format-number numberformat63 1167609)
7 EXPECTED_FOTS_FAILURE (fn-format-number numberformat64 1167609)
8-EXPECTED_FOTS_FAILURE (fn-format-number numberformat83 1167643)
9+EXPECTED_FOTS_FAILURE (fn-format-number numberformat83 1167641)
10 EXPECTED_FOTS_FAILURE (fn-format-number numberformat87 1167641)
11 EXPECTED_FOTS_FAILURE (fn-format-number numberformat88 1167641)
12 EXPECTED_FOTS_FAILURE (fn-generate-id generate-id-015 1090514)
13
14=== modified file 'test/fots_driver/environment.xq'
15--- test/fots_driver/environment.xq 2013-04-29 12:41:47 +0000
16+++ test/fots_driver/environment.xq 2013-05-17 21:06:26 +0000
17@@ -170,10 +170,12 @@
18 : to a test-case query.
19 :
20 : @param $decimal-formats decimal formats.
21+ : @param $namespaces the declared environment namespaces.
22 : @return the decimal formats declarations.
23 :)
24 declare function env:decl-decimal-formats(
25- $decimal-formats as element(fots:decimal-format)*
26+ $decimal-formats as element(fots:decimal-format)*,
27+ $namespaces as element(fots:namespace)*
28 ) as xs:string*
29 {
30 if (empty($decimal-formats))
31@@ -183,9 +185,10 @@
32 let $default := if ($tmp/@name)
33 then ()
34 else "default"
35- let $name := if ($tmp/@name)
36- then data($tmp/@name)
37- else ()
38+ let $name := xs:string($tmp/@name)
39+ let $eqName := fn:resolve-QName(xs:string($tmp/@name), $tmp)
40+ let $prefix := fn:prefix-from-QName($eqName)
41+ let $namespace := $namespaces/following-sibling::*[@uri=fn:namespace-uri-from-QName($eqName)]
42 return
43 string-join
44 (
45@@ -193,7 +196,9 @@
46 "declare",
47 $default,
48 "decimal-format",
49- $name,
50+ if(exists($prefix) and empty($namespace))
51+ then concat("Q{", namespace-uri-from-QName($eqName), "}", local-name-from-QName($eqName))
52+ else $name,
53 env:set-properties($tmp),
54 ";"
55 ),
56
57=== modified file 'test/fots_driver/fots-driver.xq'
58--- test/fots_driver/fots-driver.xq 2013-05-02 23:13:17 +0000
59+++ test/fots_driver/fots-driver.xq 2013-05-17 21:06:26 +0000
60@@ -875,7 +875,9 @@
61 env:decl-namespaces($env, $envCase, $test),
62
63 env:decl-decimal-formats(($env/fots:decimal-format,
64- $envCase/fots:decimal-format)),
65+ $envCase/fots:decimal-format),
66+ ($env/fots:namespace,
67+ $envCase/fots:namespace)),
68
69 env:add-var-decl($env, $envCase, $envBaseURI, $testSetBaseURI),
70

Subscribers

People subscribed via source and target branches