Merge lp:~zorba-coders/zorba/fix-oauth-header into lp:zorba/oauth-module

Proposed by Chris Hillery
Status: Merged
Approved by: Matthias Brantner
Approved revision: 26
Merged at revision: 26
Proposed branch: lp:~zorba-coders/zorba/fix-oauth-header
Merge into: lp:zorba/oauth-module
Diff against target: 12 lines (+1/-1)
1 file modified
src/com/zorba-xquery/www/modules/oauth/client.xq (+1/-1)
To merge this branch: bzr merge lp:~zorba-coders/zorba/fix-oauth-header
Reviewer Review Type Date Requested Status
Matthias Brantner Approve
Chris Hillery Approve
Review via email: mp+156450@code.launchpad.net

Commit message

Insert Authorization header as first node into http:request element, so it will always be valid according to the schema.

To post a comment you must log in.
Revision history for this message
Chris Hillery (ceejatec) :
review: Approve
Revision history for this message
Matthias Brantner (matthias-brantner) :
review: Approve
Revision history for this message
Zorba Build Bot (zorba-buildbot) wrote :
Revision history for this message
Zorba Build Bot (zorba-buildbot) wrote :

Validation queue job fix-oauth-header-2013-04-02T01-14-36.071Z is finished. The final status was:

All tests succeeded!

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'src/com/zorba-xquery/www/modules/oauth/client.xq'
2--- src/com/zorba-xquery/www/modules/oauth/client.xq 2012-09-28 08:54:58 +0000
3+++ src/com/zorba-xquery/www/modules/oauth/client.xq 2013-04-02 01:12:22 +0000
4@@ -567,7 +567,7 @@
5 let $signature := trace(encode-for-uri(oauth:signature($base-signature, $signature-method, $key)),"signature")
6 let $authorization-header := trace(oauth:authorization-header($params,$realm,$signature),"authorization-header")
7 let $authorization-header := <http:header name="Authorization" value="{$authorization-header}" />
8- let $request := copy $request := $protected-resource modify (insert node $authorization-header into $request) return $request
9+ let $request := copy $request := $protected-resource modify (insert node $authorization-header as first into $request) return $request
10 return http-client:send-request(
11 $request
12 )

Subscribers

People subscribed via source and target branches

to all changes: