Merge lp:~zorba-coders/zorba/fix-json-hardcoded-english into lp:zorba

Proposed by Matthias Brantner
Status: Merged
Approved by: Matthias Brantner
Approved revision: 10975
Merged at revision: 10975
Proposed branch: lp:~zorba-coders/zorba/fix-json-hardcoded-english
Merge into: lp:zorba
Diff against target: 21 lines (+2/-2)
1 file modified
src/store/naive/json_loader.cpp (+2/-2)
To merge this branch: bzr merge lp:~zorba-coders/zorba/fix-json-hardcoded-english
Reviewer Review Type Date Requested Status
Paul J. Lucas Approve
Matthias Brantner Approve
Review via email: mp+118443@code.launchpad.net

Commit message

removed some hardcoded english words from error messages raised by the json parser

Description of the change

removed some hardcoded english words from error messages raised by the json parser

To post a comment you must log in.
Revision history for this message
Matthias Brantner (matthias-brantner) :
review: Approve
Revision history for this message
Zorba Build Bot (zorba-buildbot) wrote :
Revision history for this message
Paul J. Lucas (paul-lucas) :
review: Approve
Revision history for this message
Zorba Build Bot (zorba-buildbot) wrote :

Validation queue job fix-json-hardcoded-english-2012-08-06T23-59-04.176Z is finished. The final status was:

All tests succeeded!

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'src/store/naive/json_loader.cpp'
2--- src/store/naive/json_loader.cpp 2012-07-31 10:06:14 +0000
3+++ src/store/naive/json_loader.cpp 2012-08-06 23:58:20 +0000
4@@ -71,7 +71,7 @@
5 jerr::JSDY0040, \
6 ERROR_PARAMS( \
7 ZED(msg), \
8- BUILD_STRING("line ", e.get_loc().line(), ", column ", e.get_loc().column()) \
9+ BUILD_STRING(e.get_loc().line(), ", ", e.get_loc().column()) \
10 ) \
11 ); \
12 }
13@@ -96,7 +96,7 @@
14 ERROR_PARAMS( \
15 ZED(msg), \
16 param, \
17- BUILD_STRING("line ", e.get_loc().line(), ", column ", e.get_loc().column()) \
18+ BUILD_STRING(e.get_loc().line(), ", ", e.get_loc().column()) \
19 ) \
20 ); \
21 }

Subscribers

People subscribed via source and target branches