Merge lp:~zorba-coders/zorba/fix-build-mac into lp:zorba

Proposed by Matthias Brantner
Status: Merged
Approved by: Paul J. Lucas
Approved revision: 10778
Merged at revision: 10780
Proposed branch: lp:~zorba-coders/zorba/fix-build-mac
Merge into: lp:zorba
Diff against target: 16 lines (+4/-1)
1 file modified
src/context/dynamic_context.cpp (+4/-1)
To merge this branch: bzr merge lp:~zorba-coders/zorba/fix-build-mac
Reviewer Review Type Date Requested Status
Paul J. Lucas Approve
Matthias Brantner Approve
Review via email: mp+102637@code.launchpad.net

Commit message

fix for build on mac

Description of the change

fix for build on mac

To post a comment you must log in.
Revision history for this message
Matthias Brantner (matthias-brantner) :
review: Approve
Revision history for this message
Zorba Build Bot (zorba-buildbot) wrote :
Revision history for this message
Zorba Build Bot (zorba-buildbot) wrote :

Validation queue job fix-build-mac-2012-04-19T06-45-58.526Z is finished. The final status was:

All tests succeeded!

Revision history for this message
Zorba Build Bot (zorba-buildbot) wrote :

Voting does not meet specified criteria. Required: Approve > 1, Disapprove < 1, Needs Fixing < 1, Pending < 1. Got: 1 Approve, 1 Pending.

Revision history for this message
Paul J. Lucas (paul-lucas) wrote :

Did you actually try this on a Mac? The preprocessor symbol is __APPLE__ and not APPLE.

Revision history for this message
Paul J. Lucas (paul-lucas) :
review: Approve
Revision history for this message
Zorba Build Bot (zorba-buildbot) wrote :
Revision history for this message
Zorba Build Bot (zorba-buildbot) wrote :

Validation queue job fix-build-mac-2012-04-19T14-11-53.231Z is finished. The final status was:

All tests succeeded!

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'src/context/dynamic_context.cpp'
2--- src/context/dynamic_context.cpp 2012-04-18 11:34:17 +0000
3+++ src/context/dynamic_context.cpp 2012-04-19 06:46:28 +0000
4@@ -57,8 +57,11 @@
5 using namespace std;
6
7 #ifdef UNIX
8-//external variables
9 extern char **environ;
10+# ifdef APPLE
11+# include <crt_externs.h>
12+# define environ (*_NSGetEnviron())
13+# endif
14 #endif
15
16 namespace zorba

Subscribers

People subscribed via source and target branches