Zorba

Merge lp:~zorba-coders/zorba/feature-compare_null into lp:zorba

  1. feature-compare_null
  2. Merge into trunk
Proposed by Matthias Brantner
Status: Merged
Approved by: Ghislain Fourny
Approved revision: 11393
Merged at revision: 11396
Proposed branch: lp:~zorba-coders/zorba/feature-compare_null
Merge into: lp:zorba
Diff against target: 6 lines (+1/-1)
1 file modified
test/rbkt/Queries/zorba/jsoniq/null08.jq (+1/-1)
To merge this branch: bzr merge lp:~zorba-coders/zorba/feature-compare_null
Reviewer Review Type Date Requested Status
Ghislain Fourny Approve
Matthias Brantner Approve
Review via email: mp+159871@code.launchpad.net

Commit message

added additional test comparing null eq ()

To post a comment you must log in.
Revision history for this message
Matthias Brantner (matthias-brantner) :
review: Approve
Revision history for this message
Zorba Build Bot (zorba-buildbot) wrote :

Validation queue starting for merge proposal.
Log at: http://zorbatest.lambda.nu:8080/remotequeue/feature-compare_null-2013-04-19T19-08-42.164Z/log.html

Revision history for this message
Zorba Build Bot (zorba-buildbot) wrote :

Validation queue job feature-compare_null-2013-04-19T19-08-42.164Z is finished. The final status was:

All tests succeeded!

Revision history for this message
Zorba Build Bot (zorba-buildbot) wrote :

Voting does not meet specified criteria. Required: Approve > 1, Disapprove < 1, Needs Fixing < 1, Pending < 1, Needs Information < 1, Resubmit < 1. Got: 1 Approve, 1 Pending.

Revision history for this message
Ghislain Fourny (gislenius) wrote :

Perfect!

I wondered why the .res was not modified for a wee bit of a second :-)

review: Approve
Revision history for this message
Zorba Build Bot (zorba-buildbot) wrote :

Validation queue starting for merge proposal.
Log at: http://zorbatest.lambda.nu:8080/remotequeue/feature-compare_null-2013-04-22T08-52-47.644Z/log.html

Revision history for this message
Zorba Build Bot (zorba-buildbot) wrote :

Validation queue job feature-compare_null-2013-04-22T08-52-47.644Z is finished. The final status was:

All tests succeeded!

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'test/rbkt/Queries/zorba/jsoniq/null08.jq'
2--- test/rbkt/Queries/zorba/jsoniq/null08.jq 2013-03-24 19:06:30 +0000
3+++ test/rbkt/Queries/zorba/jsoniq/null08.jq 2013-04-19 19:05:33 +0000
4@@ -1,1 +1,1 @@
5-null eq null, null ne null
6+null eq null, null ne null, null eq ()

Subscribers

People subscribed via source and target branches