Merge lp:~zorba-coders/zorba/do-not-destroy-annotations-twice into lp:zorba

Proposed by Ghislain Fourny
Status: Merged
Approved by: Markos Zaharioudakis
Approved revision: 10723
Merged at revision: 10754
Proposed branch: lp:~zorba-coders/zorba/do-not-destroy-annotations-twice
Merge into: lp:zorba
Diff against target: 11 lines (+0/-2)
1 file modified
src/system/globalenv.cpp (+0/-2)
To merge this branch: bzr merge lp:~zorba-coders/zorba/do-not-destroy-annotations-twice
Reviewer Review Type Date Requested Status
Markos Zaharioudakis Approve
Ghislain Fourny Approve
Matthias Brantner Approve
Review via email: mp+97822@code.launchpad.net

Commit message

No longer destroying built-in annotations twice.

Description of the change

No longer destroying built-in annotations twice.

To post a comment you must log in.
Revision history for this message
Zorba Build Bot (zorba-buildbot) wrote :

There are additional revisions which have not been approved in review. Please seek review and approval of these new revisions.

Revision history for this message
Zorba Build Bot (zorba-buildbot) wrote :
Revision history for this message
Zorba Build Bot (zorba-buildbot) wrote :

Validation queue job do-not-destroy-annotations-twice-2012-03-16T11-30-53.59Z is finished. The final status was:

All tests succeeded!

Revision history for this message
Zorba Build Bot (zorba-buildbot) wrote :

Voting does not meet specified criteria. Required: Approve > 1, Disapprove < 1, Needs Fixing < 1, Pending < 1. Got: 2 Pending.

Revision history for this message
Matthias Brantner (matthias-brantner) :
review: Approve
Revision history for this message
Ghislain Fourny (gislenius) :
review: Approve
Revision history for this message
Zorba Build Bot (zorba-buildbot) wrote :
Revision history for this message
Zorba Build Bot (zorba-buildbot) wrote :

Validation queue job do-not-destroy-annotations-twice-2012-04-10T13-17-05.159Z is finished. The final status was:

All tests succeeded!

Revision history for this message
Zorba Build Bot (zorba-buildbot) wrote :

Voting does not meet specified criteria. Required: Approve > 1, Disapprove < 1, Needs Fixing < 1, Pending < 1. Got: 2 Approve, 2 Pending.

Revision history for this message
Zorba Build Bot (zorba-buildbot) wrote :
Revision history for this message
Zorba Build Bot (zorba-buildbot) wrote :

Validation queue job do-not-destroy-annotations-twice-2012-04-11T18-12-53.25Z is finished. The final status was:

All tests succeeded!

Revision history for this message
Zorba Build Bot (zorba-buildbot) wrote :

Voting does not meet specified criteria. Required: Approve > 1, Disapprove < 1, Needs Fixing < 1, Pending < 1. Got: 2 Approve, 2 Pending.

Revision history for this message
Markos Zaharioudakis (markos-za) :
review: Approve
Revision history for this message
Zorba Build Bot (zorba-buildbot) wrote :
Revision history for this message
Zorba Build Bot (zorba-buildbot) wrote :

Validation queue job do-not-destroy-annotations-twice-2012-04-12T08-49-57.873Z is finished. The final status was:

All tests succeeded!

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'src/system/globalenv.cpp'
2--- src/system/globalenv.cpp 2012-01-11 17:30:25 +0000
3+++ src/system/globalenv.cpp 2012-03-16 10:11:26 +0000
4@@ -153,8 +153,6 @@
5
6 BuiltinFunctionLibrary::destroy();
7
8- AnnotationInternal::destroyBuiltIn();
9-
10 delete m_globalEnv;
11 m_globalEnv = NULL;
12

Subscribers

People subscribed via source and target branches