Merge lp:~zorba-coders/zorba/csharp-win-installer-fix into lp:zorba

Proposed by Juan Zacarias
Status: Merged
Approved by: Rodolfo Ochoa
Approved revision: 10971
Merged at revision: 10974
Proposed branch: lp:~zorba-coders/zorba/csharp-win-installer-fix
Merge into: lp:zorba
Diff against target: 76 lines (+12/-5)
3 files modified
CMakeCPack.cmake (+5/-2)
doc/CMakeLists.txt (+4/-0)
swig/csharp/CMakeLists.txt (+3/-3)
To merge this branch: bzr merge lp:~zorba-coders/zorba/csharp-win-installer-fix
Reviewer Review Type Date Requested Status
Rodolfo Ochoa Approve
Chris Hillery Approve
Review via email: mp+118212@code.launchpad.net

Commit message

Fixed windows installer component options for c# Bindings

To post a comment you must log in.
10970. By Juan Zacarias

Windows Installer change: Added thesaurus and csharp Bindings to Full installation type

Revision history for this message
Chris Hillery (ceejatec) wrote :

Changes look good, but can you revert the line-endings change to NOTICE.xml?

review: Needs Fixing
Revision history for this message
Chris Hillery (ceejatec) wrote :

Er, NOTICE.txt, that is.

10971. By Juan Zacarias

reverted change on NOTICE.txt

Revision history for this message
Juan Zacarias (juan457) wrote :

> Er, NOTICE.txt, that is.
Fixed

Revision history for this message
Chris Hillery (ceejatec) :
review: Approve
Revision history for this message
Rodolfo Ochoa (rodolfo-ochoa) :
review: Approve
Revision history for this message
Zorba Build Bot (zorba-buildbot) wrote :
Revision history for this message
Zorba Build Bot (zorba-buildbot) wrote :

Validation queue job csharp-win-installer-fix-2012-08-06T22-59-02.344Z is finished. The final status was:

All tests succeeded!

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'CMakeCPack.cmake'
2--- CMakeCPack.cmake 2012-08-03 04:35:01 +0000
3+++ CMakeCPack.cmake 2012-08-06 17:21:38 +0000
4@@ -33,6 +33,7 @@
5 SET(CPACK_COMPONENT_RUBY_SWIG_DISPLAY_NAME "Ruby API")
6 SET(CPACK_COMPONENT_XQJ_SWIG_DISPLAY_NAME "Java XQJ API")
7 SET(CPACK_COMPONENT_THESAURUS_DISPLAY_NAME "Thesaurus")
8+SET(CPACK_COMPONENT_CSHARP_SWIG_DISPLAY_NAME "C# API")
9
10 SET(CPACK_COMPONENT_UNSPECIFIED_DESCRIPTION "Zorba Required Files.")
11 SET(CPACK_COMPONENT_DOC_DESCRIPTION "Files with the Description of different features of zorba.")
12@@ -46,6 +47,7 @@
13 SET(CPACK_COMPONENT_RUBY_SWIG_DESCRIPTION "API for Ruby")
14 SET(CPACK_COMPONENT_XQJ_SWIG_DESCRIPTION "XQJ API for Java")
15 SET(CPACK_COMPONENT_THESAURUS_DESCRIPTION "Thesaurus for Zorba")
16+SET(CPACK_COMPONENT_CSHARP_SWIG_DESCRIPTION "API for C#")
17
18 SET(CPACK_COMPONENT_DOC_GROUP "Documents")
19 SET(CPACK_COMPONENT_PHP_EXAMPLES_GROUP "Documents")
20@@ -58,6 +60,7 @@
21 SET(CPACK_COMPONENT_PYTHON_SWIG_GROUP "APIs")
22 SET(CPACK_COMPONENT_RUBY_SWIG_GROUP "APIs")
23 SET(CPACK_COMPONENT_XQJ_SWIG_GROUP "APIs")
24+SET(CPACK_COMPONENT_CSHARP_SWIG_GROUP "APIs")
25
26 SET(CPACK_COMPONENT_GROUP_EXTERNAL_MODULES_DISPLAY_NAME "External Modules")
27 SET(CPACK_COMPONENT_GROUP_EXTERNAL_MODULES_DESCRIPTION "Complete list of external modules.")
28@@ -77,8 +80,8 @@
29 SET(CPACK_COMPONENT_RUBY_SWIG_INSTALL_TYPES Full)
30 SET(CPACK_COMPONENT_XQJ_SWIG_INSTALL_TYPES Full)
31 SET(CPACK_COMPONENT_UNSPECIFIED_INSTALL_TYPES Full Simple Lite)
32-SET(CPACK_COMPONENT_THESAURUS_INSTALL_TYPE Full)
33-
34+SET(CPACK_COMPONENT_THESAURUS_INSTALL_TYPES Full)
35+SET(CPACK_COMPONENT_CSHARP_SWIG_INSTALL_TYPES Full)
36
37 INCLUDE(${CMAKE_BINARY_DIR}/CMakeCPackModules.cmake)
38
39
40=== modified file 'doc/CMakeLists.txt'
41--- doc/CMakeLists.txt 2012-07-30 20:09:08 +0000
42+++ doc/CMakeLists.txt 2012-08-06 17:21:38 +0000
43@@ -97,6 +97,10 @@
44 INSTALL(DIRECTORY ${CMAKE_CURRENT_BINARY_DIR}/xqj/html
45 COMPONENT "doc"
46 DESTINATION share/doc/zorba-${ZORBA_MAJOR_NUMBER}.${ZORBA_MINOR_NUMBER}.${ZORBA_PATCH_NUMBER}/xqj)
47+
48+ INSTALL(DIRECTORY ${CMAKE_CURRENT_BINARY_DIR}/csharp/html
49+ COMPONENT "doc"
50+ DESTINATION share/doc/zorba-${ZORBA_MAJOR_NUMBER}.${ZORBA_MINOR_NUMBER}.${ZORBA_PATCH_NUMBER}/csharp)
51 ENDIF (SWIG_FOUND)
52
53 INSTALL(DIRECTORY ${CMAKE_CURRENT_BINARY_DIR}/zorba/html
54
55=== modified file 'swig/csharp/CMakeLists.txt'
56--- swig/csharp/CMakeLists.txt 2012-07-30 20:09:08 +0000
57+++ swig/csharp/CMakeLists.txt 2012-08-06 17:21:38 +0000
58@@ -38,16 +38,16 @@
59 IF (MSVC_IDE)
60 INSTALL(FILES ${CMAKE_CURRENT_BINARY_DIR}/${CMAKE_BUILD_TYPE}/zorba_api.dll
61 DESTINATION share/csharp
62- COMPONENT "C# Bindings ")
63+ COMPONENT csharp_swig)
64 ELSE (MSVC_IDE)
65 INSTALL(FILES ${CMAKE_CURRENT_BINARY_DIR}/zorba_api.dll
66 DESTINATION share/csharp
67- COMPONENT "C# Bindings ")
68+ COMPONENT csharp_swig)
69 ENDIF (MSVC_IDE)
70
71 INSTALL(FILES ${CMAKE_CURRENT_BINARY_DIR}/zorba_csharp.dll
72 DESTINATION share/csharp
73- COMPONENT "C# Bindings ")
74+ COMPONENT csharp_swig)
75
76 ADD_SUBDIRECTORY (tests)
77

Subscribers

People subscribed via source and target branches