Merge lp:~zorba-coders/zorba/create-user-typed-atomic-item into lp:zorba

[Ghislain Fourny]

Introduces an item factory function to create atomic items with a user-defined type.

Introduces an item factory function to create atomic items with a user-defined type.

[Zorba Build Bot (zorba-buildbot)]

Validation queue starting for merge proposal.
Log at: http://zorbatest.lambda.nu:8080/remotequeue/create-user-typed-atomic-item-2012-08-21T13-23-59.457Z/log.html

[Zorba Build Bot (zorba-buildbot)]

Validation queue job create-user-typed-atomic-item-2012-08-21T13-23-59.457Z is finished. The final status was:

All tests succeeded!

[Zorba Build Bot (zorba-buildbot)]

Voting does not meet specified criteria. Required: Approve > 1, Disapprove < 1, Needs Fixing < 1, Pending < 1. Got: 3 Pending.

[Matthias Brantner (matthias-brantner)]

review: Approve

[Markos Zaharioudakis (markos-za)]

review: Approve

[Zorba Build Bot (zorba-buildbot)]

Validation queue starting for merge proposal.
Log at: http://zorbatest.lambda.nu:8080/remotequeue/create-user-typed-atomic-item-2012-09-09T08-02-47.326Z/log.html

[Zorba Build Bot (zorba-buildbot)]

Validation queue job create-user-typed-atomic-item-2012-09-09T08-02-47.326Z is finished. The final status was:

All tests succeeded!

[Zorba Build Bot (zorba-buildbot)]

Validation queue starting for merge proposal.
Log at: http://zorbatest.lambda.nu:8080/remotequeue/create-user-typed-atomic-item-2012-09-09T08-15-54.402Z/log.html

[Zorba Build Bot (zorba-buildbot)]

Validation queue job create-user-typed-atomic-item-2012-09-09T08-15-54.402Z is finished. The final status was:

All tests succeeded!

[Zorba Build Bot (zorba-buildbot)]

Validation queue starting for merge proposal.
Log at: http://zorbatest.lambda.nu:8080/remotequeue/create-user-typed-atomic-item-2012-09-09T08-39-59.249Z/log.html

[Zorba Build Bot (zorba-buildbot)]

Validation queue job create-user-typed-atomic-item-2012-09-09T08-39-59.249Z is finished. The final status was:

All tests succeeded!

[Zorba Build Bot (zorba-buildbot)]

Validation queue starting for merge proposal.
Log at: http://zorbatest.lambda.nu:8080/remotequeue/create-user-typed-atomic-item-2012-09-09T09-04-02.857Z/log.html

[Zorba Build Bot (zorba-buildbot)]

Validation queue job create-user-typed-atomic-item-2012-09-09T09-04-02.857Z is finished. The final status was:

All tests succeeded!

[Zorba Build Bot (zorba-buildbot)]

Validation queue starting for merge proposal.
Log at: http://zorbatest.lambda.nu:8080/remotequeue/create-user-typed-atomic-item-2012-09-09T09-35-10.718Z/log.html

[Zorba Build Bot (zorba-buildbot)]

Validation queue job create-user-typed-atomic-item-2012-09-09T09-35-10.718Z is finished. The final status was:

All tests succeeded!

[Zorba Build Bot (zorba-buildbot)]

Validation queue starting for merge proposal.
Log at: http://zorbatest.lambda.nu:8080/remotequeue/create-user-typed-atomic-item-2012-09-09T09-43-43.754Z/log.html

[Zorba Build Bot (zorba-buildbot)]

Validation queue starting for merge proposal.
Log at: http://zorbatest.lambda.nu:8080/remotequeue/create-user-typed-atomic-item-2012-09-09T09-53-00.214Z/log.html

[Zorba Build Bot (zorba-buildbot)]

Validation queue starting for merge proposal.
Log at: http://zorbatest.lambda.nu:8080/remotequeue/create-user-typed-atomic-item-2012-09-09T09-56-43.59Z/log.html

[Zorba Build Bot (zorba-buildbot)]

Validation queue job create-user-typed-atomic-item-2012-09-09T09-56-43.59Z is finished. The final status was:

All tests succeeded!

[Zorba Build Bot (zorba-buildbot)]

Validation queue starting for merge proposal.
Log at: http://zorbatest.lambda.nu:8080/remotequeue/create-user-typed-atomic-item-2012-09-09T10-05-56.574Z/log.html

[Zorba Build Bot (zorba-buildbot)]

Validation queue starting for merge proposal.
Log at: http://zorbatest.lambda.nu:8080/remotequeue/create-user-typed-atomic-item-2012-09-09T10-08-41.336Z/log.html

[Zorba Build Bot (zorba-buildbot)]

Validation queue starting for merge proposal.
Log at: http://zorbatest.lambda.nu:8080/remotequeue/create-user-typed-atomic-item-2012-09-09T10-09-42.663Z/log.html

[Zorba Build Bot (zorba-buildbot)]

Validation queue job create-user-typed-atomic-item-2012-09-09T10-09-42.663Z is finished. The final status was:

All tests succeeded!

[Zorba Build Bot (zorba-buildbot)]

Validation queue starting for merge proposal.
Log at: http://zorbatest.lambda.nu:8080/remotequeue/create-user-typed-atomic-item-2012-09-09T10-21-41.198Z/log.html

[Zorba Build Bot (zorba-buildbot)]

Validation queue job create-user-typed-atomic-item-2012-09-09T10-21-41.198Z is finished. The final status was:

All tests succeeded!

[Zorba Build Bot (zorba-buildbot)]

Validation queue starting for merge proposal.
Log at: http://zorbatest.lambda.nu:8080/remotequeue/create-user-typed-atomic-item-2012-09-09T10-41-42.261Z/log.html

[Zorba Build Bot (zorba-buildbot)]

Validation queue job create-user-typed-atomic-item-2012-09-09T10-41-42.261Z is finished. The final status was:

All tests succeeded!

[Zorba Build Bot (zorba-buildbot)]

Validation queue starting for merge proposal.
Log at: http://zorbatest.lambda.nu:8080/remotequeue/create-user-typed-atomic-item-2012-09-09T10-47-46.656Z/log.html

[Zorba Build Bot (zorba-buildbot)]

Validation queue job create-user-typed-atomic-item-2012-09-09T10-47-46.656Z is finished. The final status was:

All tests succeeded!

[Zorba Build Bot (zorba-buildbot)]

Validation queue starting for merge proposal.
Log at: http://zorbatest.lambda.nu:8080/remotequeue/create-user-typed-atomic-item-2012-09-10T07-45-51.739Z/log.html

[Zorba Build Bot (zorba-buildbot)]

Validation queue job create-user-typed-atomic-item-2012-09-10T07-45-51.739Z is finished. The final status was:

All tests succeeded!

[Zorba Build Bot (zorba-buildbot)]

Validation queue starting for merge proposal.
Log at: http://zorbatest.lambda.nu:8080/remotequeue/create-user-typed-atomic-item-2012-09-10T08-10-48.025Z/log.html

[Zorba Build Bot (zorba-buildbot)]

Validation queue job create-user-typed-atomic-item-2012-09-10T08-10-48.025Z is finished. The final status was:

All tests succeeded!

[Zorba Build Bot (zorba-buildbot)]

Validation queue starting for merge proposal.
Log at: http://zorbatest.lambda.nu:8080/remotequeue/create-user-typed-atomic-item-2012-09-10T08-23-47.376Z/log.html

[Zorba Build Bot (zorba-buildbot)]

Validation queue job create-user-typed-atomic-item-2012-09-10T08-23-47.376Z is finished. The final status was:

All tests succeeded!

=== modified file 'include/zorba/item_factory.h'
--- include/zorba/item_factory.h	2012-08-16 18:31:02 +0000
+++ include/zorba/item_factory.h	2012-08-21 13:23:26 +0000
@@ -778,6 +778,17 @@
       assignElementTypedValue(Item& aElement,
                               std::vector<Item>& aTypedValue) = 0;
 
+      /**
+       * Create an atomic item having a user-defined atomic type.
+       *
+       * @param aBaseItem the base item of the item to create.
+       * @param aTypeName the name of the type of the item to create.
+       *
+       * @return a new atomic item having the given user-defined atomic type.
+       */
+      virtual Item
+      createUserTypedAtomicItem(Item& aBaseItem, Item& aTypeName) = 0;
+
   }; // class ItemFactory
 
 } // namespace zorba

=== modified file 'src/api/itemfactoryimpl.cpp'
--- src/api/itemfactoryimpl.cpp	2012-08-16 18:31:02 +0000
+++ src/api/itemfactoryimpl.cpp	2012-08-21 13:23:26 +0000
@@ -950,11 +950,18 @@
   return &*lItem;
 }
 
-
-
-
 #endif /* ZORBA_WITH_JSON */
 
+zorba::Item ItemFactoryImpl::createUserTypedAtomicItem(
+    Item& aBaseItem,
+    Item& aTypeName)
+{
+  store::Item_t lRes;
+  store::Item_t lBaseItem = Unmarshaller::getInternalItem(aBaseItem);
+  store::Item_t lTypeName = Unmarshaller::getInternalItem(aTypeName);
+  theItemFactory->createUserTypedAtomicItem(lRes, lBaseItem, lTypeName);
+  return &*lRes;
+}
 
 } // namespace zorba
 /* vim:set et sw=2 ts=2: */

=== modified file 'src/api/itemfactoryimpl.h'
--- src/api/itemfactoryimpl.h	2012-08-16 18:31:02 +0000
+++ src/api/itemfactoryimpl.h	2012-08-21 13:23:26 +0000
@@ -278,6 +278,9 @@
 
 #endif /* ZORBA_WITH_JSON */
 
+      virtual Item
+      createUserTypedAtomicItem(Item& aBaseItem, Item& aTypeName);
+
     protected:
       store::ItemFactory* theItemFactory;