Merge lp:~zorba-coders/zorba/cleanup-guestbook.xq into lp:zorba

Proposed by Till Westmann
Status: Merged
Approved by: Till Westmann
Approved revision: 10878
Merged at revision: 10879
Proposed branch: lp:~zorba-coders/zorba/cleanup-guestbook.xq
Merge into: lp:zorba
Diff against target: 31 lines (+7/-7)
1 file modified
test/unit/guestbook.xq (+7/-7)
To merge this branch: bzr merge lp:~zorba-coders/zorba/cleanup-guestbook.xq
Reviewer Review Type Date Requested Status
Ghislain Fourny Approve
Till Westmann Approve
Review via email: mp+110413@code.launchpad.net

Commit message

remove unnecessary annotations and clean-up indentation

Description of the change

remove unnecessary annotations and clean-up indentation

To post a comment you must log in.
Revision history for this message
Till Westmann (tillw) :
review: Approve
Revision history for this message
Zorba Build Bot (zorba-buildbot) wrote :
Revision history for this message
Zorba Build Bot (zorba-buildbot) wrote :

Validation queue job cleanup-guestbook.xq-2012-06-14T21-30-02.066Z is finished. The final status was:

All tests succeeded!

Revision history for this message
Zorba Build Bot (zorba-buildbot) wrote :

Voting does not meet specified criteria. Required: Approve > 1, Disapprove < 1, Needs Fixing < 1, Pending < 1. Got: 1 Approve, 1 Pending.

Revision history for this message
Ghislain Fourny (gislenius) :
review: Approve
Revision history for this message
Zorba Build Bot (zorba-buildbot) wrote :
Revision history for this message
Zorba Build Bot (zorba-buildbot) wrote :

Validation queue job cleanup-guestbook.xq-2012-06-15T16-02-59.705Z is finished. The final status was:

All tests succeeded!

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'test/unit/guestbook.xq'
2--- test/unit/guestbook.xq 2012-05-03 12:31:51 +0000
3+++ test/unit/guestbook.xq 2012-06-14 20:56:22 +0000
4@@ -21,10 +21,10 @@
5
6 declare namespace ann = "http://www.zorba-xquery.com/annotations";
7
8-declare %ann:ordered collection guestbook:entries as node()*;
9+declare collection guestbook:entries as node()*;
10 declare variable $guestbook:entries as xs:QName := xs:QName("guestbook:entries");
11
12-declare %ann:sequential function guestbook:list()
13+declare function guestbook:list()
14 {
15 let $entries := dml:collection($guestbook:entries)
16 let $num_entries := fn:count($entries)
17@@ -38,11 +38,11 @@
18 };
19
20 declare function guestbook:window() {
21- let $x := 1 to 1000
22- for tumbling window $w in $x
23- start at $s when fn:true()
24- end at $e when $e - $s eq 51
25- return <window>{ $w }</window>
26+ let $x := 1 to 1000
27+ for tumbling window $w in $x
28+ start at $s when fn:true()
29+ end at $e when $e - $s eq 51
30+ return <window>{ $w }</window>
31 };
32
33

Subscribers

People subscribed via source and target branches