Merge lp:~zorba-coders/zorba/checkout-modules into lp:zorba

Proposed by Chris Hillery
Status: Rejected
Rejected by: Chris Hillery
Proposed branch: lp:~zorba-coders/zorba/checkout-modules
Merge into: lp:zorba
Diff against target: 12 lines (+2/-1)
1 file modified
modules/DownloadModules.cmake (+2/-1)
To merge this branch: bzr merge lp:~zorba-coders/zorba/checkout-modules
Reviewer Review Type Date Requested Status
Chris Hillery Disapprove
Review via email: mp+107191@code.launchpad.net

Commit message

Use "bzr co --lightweight" rather than "bzr branch" when downloading non-core modules.

To post a comment you must log in.
Revision history for this message
Chris Hillery (ceejatec) :
review: Approve
Revision history for this message
Zorba Build Bot (zorba-buildbot) wrote :
Revision history for this message
Zorba Build Bot (zorba-buildbot) wrote :

Validation queue job checkout-modules-2012-05-24T10-53-02.008Z is finished. The final status was:

All tests succeeded!

Revision history for this message
Zorba Build Bot (zorba-buildbot) wrote :

Voting does not meet specified criteria. Required: Approve > 1, Disapprove < 1, Needs Fixing < 1, Pending < 1. Got: 1 Approve.

Revision history for this message
Chris Hillery (ceejatec) wrote :

It seems that this is no longer desirable.

review: Disapprove

Unmerged revisions

10867. By Chris Hillery

Use "bzr co --lightweight" rather than "bzr branch" when downloading non-core
modules.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'modules/DownloadModules.cmake'
2--- modules/DownloadModules.cmake 2012-05-03 12:31:51 +0000
3+++ modules/DownloadModules.cmake 2012-05-24 10:36:20 +0000
4@@ -103,7 +103,8 @@
5 if (_modtag AND NOT notags)
6 set (_modtagargs "-r" "${_modtag}")
7 endif (_modtag AND NOT notags)
8- execute_process (COMMAND "${bzr}" branch "${_modurl}" "${_modname}"
9+ execute_process (COMMAND "${bzr}" co --lightweight
10+ "${_modurl}" "${_modname}"
11 ${_modtagargs} WORKING_DIRECTORY "${outdir}" TIMEOUT 60
12 RESULT_VARIABLE _status)
13

Subscribers

People subscribed via source and target branches