Merge lp:~zorba-coders/zorba/bug955040 into lp:zorba/data-formatting-module
Proposed by
Rodolfo Ochoa
Status: | Merged | ||||
---|---|---|---|---|---|
Approved by: | Matthias Brantner | ||||
Approved revision: | 31 | ||||
Merged at revision: | 30 | ||||
Proposed branch: | lp:~zorba-coders/zorba/bug955040 | ||||
Merge into: | lp:zorba/data-formatting-module | ||||
Diff against target: |
205 lines (+79/-81) 2 files modified
CMakeLists.txt (+4/-0) src/com/zorba-xquery/www/modules/CMakeLists.txt (+75/-81) |
||||
To merge this branch: | bzr merge lp:~zorba-coders/zorba/bug955040 | ||||
Related bugs: |
|
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Matthias Brantner | Approve | ||
Chris Hillery | Approve | ||
Cezar Andrei | Approve | ||
Review via email: mp+98891@code.launchpad.net |
Commit message
Fixes on CMakeList to avoid submitting a test when module is not active.
Also added functionality to avoid testing for Java if module is not active.
Description of the change
Fixes on CMakeList to avoid submitting a test when module is not active.
Also added functionality to avoid testing for Java if module is not active.
To post a comment you must log in.
1. ZORBA_WITH_FOP means I really want FOP. Ie if there is anything missing it's an error.
So if ZORBA_WITH_FOP and ZORBA_SUPPRESS_JAVA are both true should be an error.
2. Why did you replace 1 IF with AND condition with 8 nested IF's ?