Merge lp:~zorba-coders/zorba/bug911956 into lp:zorba

Proposed by Matthias Brantner
Status: Superseded
Proposed branch: lp:~zorba-coders/zorba/bug911956
Merge into: lp:zorba
Diff against target: 12 lines (+2/-0)
1 file modified
test/unit/datetime.cpp (+2/-0)
To merge this branch: bzr merge lp:~zorba-coders/zorba/bug911956
Reviewer Review Type Date Requested Status
Martin Gieseking (community) Needs Information
Matthias Brantner Approve
Review via email: mp+87529@code.launchpad.net

This proposal has been superseded by a proposal from 2012-01-04.

Commit message

fixed build for gcc 4.7.x (fixes bug #911956)

Description of the change

fixed build for gcc 4.7.x (fixes bug #911956)

To post a comment you must log in.
Revision history for this message
Matthias Brantner (matthias-brantner) :
review: Approve
Revision history for this message
Zorba Build Bot (zorba-buildbot) wrote :
Revision history for this message
Zorba Build Bot (zorba-buildbot) wrote :

Validation queue job bug911956-2012-01-04T20-23-03.043Z is finished. The final status was:

All tests succeeded!

Revision history for this message
Zorba Build Bot (zorba-buildbot) wrote :

Voting does not meet specified criteria. Required: Approve > 1, Disapprove < 1. Got: 1 Approve.

Revision history for this message
Martin Gieseking (martin-gieseking) wrote :

Since most Windows compilers don't provide unistd.h, I suggest to use my patch attached to the bug report which excludes the header file from Windows builds. This shouldn't be a problem as the prototype of sleep() included by unistd.h is defined separately in the patched source file.

review: Needs Information
lp:~zorba-coders/zorba/bug911956 updated
10602. By Matthias Brantner

unistd.h is not available on most Windows compilers

Unmerged revisions

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'test/unit/datetime.cpp'
2--- test/unit/datetime.cpp 2011-06-14 17:26:33 +0000
3+++ test/unit/datetime.cpp 2012-01-04 21:39:42 +0000
4@@ -21,6 +21,8 @@
5 #ifdef WIN32
6 # include <windows.h>
7 # define sleep(s) Sleep(s*1000)
8+#else
9+# include <unistd.h>
10 #endif
11
12 #include <zorba/store_manager.h>

Subscribers

People subscribed via source and target branches