Merge lp:~zorba-coders/zorba/bug1132937b into lp:zorba/jdbc-module

Proposed by Rodolfo Ochoa
Status: Merged
Approved by: Matthias Brantner
Approved revision: 48
Merged at revision: 48
Proposed branch: lp:~zorba-coders/zorba/bug1132937b
Merge into: lp:zorba/jdbc-module
Diff against target: 12 lines (+0/-2)
1 file modified
src/jdbc.xq.src/jsonitemsequence.cpp (+0/-2)
To merge this branch: bzr merge lp:~zorba-coders/zorba/bug1132937b
Reviewer Review Type Date Requested Status
Matthias Brantner Approve
Rodolfo Ochoa Approve
Review via email: mp+158726@code.launchpad.net

Commit message

Fix for an unnecessary cursor movement call. Using this function would raise an exception if the database driver decides to create a forward only cursor (e.g. Microsoft SQL Server).

Description of the change

Fix for an unnecessary cursor movement call

To post a comment you must log in.
Revision history for this message
Zorba Build Bot (zorba-buildbot) wrote :
Revision history for this message
Zorba Build Bot (zorba-buildbot) wrote :

Validation queue job bug1132937b-2013-04-12T22-45-42.116Z is finished. The final status was:

All tests succeeded!

Revision history for this message
Zorba Build Bot (zorba-buildbot) wrote :

Voting does not meet specified criteria. Required: Approve > 1, Disapprove < 1, Needs Fixing < 1, Pending < 1, Needs Information < 1, Resubmit < 1. Got: 1 Pending.

Revision history for this message
Rodolfo Ochoa (rodolfo-ochoa) :
review: Approve
Revision history for this message
Matthias Brantner (matthias-brantner) :
review: Approve
Revision history for this message
Zorba Build Bot (zorba-buildbot) wrote :
Revision history for this message
Zorba Build Bot (zorba-buildbot) wrote :

Validation queue job bug1132937b-2013-04-13T01-14-42.669Z is finished. The final status was:

All tests succeeded!

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'src/jdbc.xq.src/jsonitemsequence.cpp'
2--- src/jdbc.xq.src/jsonitemsequence.cpp 2013-02-02 04:36:34 +0000
3+++ src/jdbc.xq.src/jsonitemsequence.cpp 2013-04-12 22:44:27 +0000
4@@ -34,8 +34,6 @@
5 CHECK_EXCEPTION
6 columnCount = env->CallIntMethod(oMetadata, jResultSetMetadata.getColumnCount);
7 CHECK_EXCEPTION
8- env->CallVoidMethod(oResultSet, jResultSet.beforeFirst);
9- CHECK_EXCEPTION
10
11 // Getting column names and types
12 columnNames = new String[columnCount];

Subscribers

People subscribed via source and target branches

to all changes: