Merge lp:~zorba-coders/zorba/bug1099622 into lp:zorba

Proposed by Rodolfo Ochoa
Status: Merged
Approved by: Rodolfo Ochoa
Approved revision: 11180
Merged at revision: 11184
Proposed branch: lp:~zorba-coders/zorba/bug1099622
Merge into: lp:zorba
Diff against target: 38 lines (+9/-9)
1 file modified
cmake_modules/FindPHP5.cmake (+9/-9)
To merge this branch: bzr merge lp:~zorba-coders/zorba/bug1099622
Reviewer Review Type Date Requested Status
Rodolfo Ochoa Approve
Juan Zacarias Approve
Review via email: mp+143213@code.launchpad.net

Commit message

Fix for PHP finding on Windows

Description of the change

Fix for PHP finding on Windows

To post a comment you must log in.
Revision history for this message
Juan Zacarias (juan457) :
review: Approve
Revision history for this message
Rodolfo Ochoa (rodolfo-ochoa) :
review: Approve
Revision history for this message
Zorba Build Bot (zorba-buildbot) wrote :
Revision history for this message
Zorba Build Bot (zorba-buildbot) wrote :

Validation queue job bug1099622-2013-01-15T00-36-14.137Z is finished. The final status was:

All tests succeeded!

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'cmake_modules/FindPHP5.cmake'
2--- cmake_modules/FindPHP5.cmake 2012-10-18 00:03:08 +0000
3+++ cmake_modules/FindPHP5.cmake 2013-01-15 00:03:22 +0000
4@@ -157,16 +157,18 @@
5 ENDIF(PHP5_VERSION LESS 5)
6
7 ELSE (NOT WIN32 OR CYGWIN)
8-MESSAGE(STATUS "Windows Environment Configuration...")
9-#On Windows, set PHP5_INCLUDE_DIR with -D
10-MESSAGE(STATUS "Path to source: " ${PHP5_INCLUDE_DIR})
11-SET(PHP5_INCLUDES ${PHP5_INCLUDE_DIR})
12-#SET(PHP5_EXTENSION_DIR "" CACHE PATH "Path to the ext subdir in binary PHP5")
13-ENDIF (NOT WIN32 OR CYGWIN)
14-
15+
16+################ WINDOWS CONFIG
17+
18 IF(NOT PHP5_INCLUDE_DIR )
19 SET (PHP5_INCLUDE_DIR ${CMAKE_PREFIX_PATH})
20 ENDIF(NOT PHP5_INCLUDE_DIR )
21+
22+MESSAGE(STATUS "Windows Environment Configuration.")
23+MESSAGE(STATUS "PHP Path: " ${PHP5_INCLUDE_DIR})
24+SET(PHP5_INCLUDES ${PHP5_INCLUDE_DIR})
25+
26+ENDIF (NOT WIN32 OR CYGWIN)
27
28 set(PHP5_MAIN_INCLUDE_DIR ${PHP5_INCLUDE_DIR}/main)
29 set(PHP5_TSRM_INCLUDE_DIR ${PHP5_INCLUDE_DIR}/TSRM)
30@@ -176,8 +178,6 @@
31 set(PHP5_DATE_INCLUDE_DIR ${PHP5_INCLUDE_DIR}/ext/date/lib)
32 set(PHP5_STANDARD_INCLUDE_DIR ${PHP5_INCLUDE_DIR}/ext/standard)
33
34-MESSAGE(STATUS ${PHP5_MAIN_INCLUDE_DIR})
35-
36 IF(PHP5_EXECUTABLE AND PHP5_INCLUDES)
37 SET(PHP5_FOUND "yes")
38 MESSAGE(STATUS "Found PHP5-Version ${PHP5_VERSION}")

Subscribers

People subscribed via source and target branches