Merge lp:~zorba-coders/zorba/bug-872386 into lp:zorba

Proposed by Chris Hillery
Status: Merged
Approved by: Juan Zacarias
Approved revision: 10797
Merged at revision: 10811
Proposed branch: lp:~zorba-coders/zorba/bug-872386
Merge into: lp:zorba
Diff against target: 25 lines (+15/-0)
1 file modified
doc/zorba/modules_authoring_2.dox (+15/-0)
To merge this branch: bzr merge lp:~zorba-coders/zorba/bug-872386
Reviewer Review Type Date Requested Status
Juan Zacarias Approve
Chris Hillery Approve
Review via email: mp+103411@code.launchpad.net

Commit message

Added note about re-running CMake if you add or remove .cpp files in your module source directory.

To post a comment you must log in.
Revision history for this message
Chris Hillery (ceejatec) :
review: Approve
Revision history for this message
Juan Zacarias (juan457) :
review: Approve
Revision history for this message
Zorba Build Bot (zorba-buildbot) wrote :
Revision history for this message
Zorba Build Bot (zorba-buildbot) wrote :

Validation queue job bug-872386-2012-05-02T07-25-01.16Z is finished. The final status was:

All tests succeeded!

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'doc/zorba/modules_authoring_2.dox'
2--- doc/zorba/modules_authoring_2.dox 2012-04-24 12:39:38 +0000
3+++ doc/zorba/modules_authoring_2.dox 2012-04-25 06:08:44 +0000
4@@ -318,6 +318,21 @@
5 directory will be set in a CMake variable by the
6 <tt>FIND_PACKAGE()</tt> command.
7
8+Important note: <tt>DECLARE_ZORBA_MODULE</tt> discovers all
9+<tt>.cpp</tt> files in the source directory automatically, using a
10+glob pattern (i.e., <tt>*.cpp</tt>). This is convenient, but it does
11+have a hidden downside: If you add new <tt>.cpp</tt> files to this
12+directory, CMake has no way of knowing that you have done so, and so
13+those files will not automatically get built. This can lead to strange
14+compilation or runtime errors. Fortunately, there is a simple
15+solution: Whenever you add new <tt>.cpp</tt> files for a module,
16+always remember to immediately re-run <tt>cmake</tt> in your build
17+directory. This will cause the glob pattern to be re-run and will pick
18+up any new source code files. Likewise, if you delete any
19+<tt>.cpp</tt> files from your source directory, you will need to
20+re-run <tt>cmake</tt> for the same reason - although at least in that
21+case you will get a clear error message if you forget to do so.
22+
23 \section mod_author_declare_synopsis Zorba Module CMake Macros: Summary
24
25 For reference, here is the complete set of options for all macros

Subscribers

People subscribed via source and target branches