Merge lp:~zorba-coders/zorba/bug-1067028-no-json into lp:zorba

Proposed by Till Westmann
Status: Merged
Approved by: Chris Hillery
Approved revision: 11102
Merged at revision: 11148
Proposed branch: lp:~zorba-coders/zorba/bug-1067028-no-json
Merge into: lp:zorba
Diff against target: 213 lines (+27/-7)
10 files modified
src/api/serialization/serializer.cpp (+2/-0)
src/compiler/rewriter/rules/type_rules.cpp (+2/-0)
src/functions/pregenerated/func_jsoniq_functions.cpp (+7/-1)
src/functions/pregenerated/func_jsoniq_functions.h (+2/-1)
src/runtime/json/pregenerated/jsoniq_functions.cpp (+2/-1)
src/runtime/json/pregenerated/jsoniq_functions.h (+2/-0)
src/runtime/spec/json/jsoniq_functions.xml (+2/-1)
src/runtime/visitors/pregenerated/planiter_visitor.h (+4/-2)
src/runtime/visitors/pregenerated/printer_visitor.cpp (+2/-1)
src/runtime/visitors/pregenerated/printer_visitor.h (+2/-0)
To merge this branch: bzr merge lp:~zorba-coders/zorba/bug-1067028-no-json
Reviewer Review Type Date Requested Status
Markos Zaharioudakis Approve
Till Westmann Approve
Review via email: mp+129743@code.launchpad.net

Commit message

fix compilation without ZORBA_WITH_JSON

Description of the change

fix compilation without ZORBA_WITH_JSON

To post a comment you must log in.
Revision history for this message
Till Westmann (tillw) :
review: Approve
Revision history for this message
Zorba Build Bot (zorba-buildbot) wrote :
Revision history for this message
Zorba Build Bot (zorba-buildbot) wrote :

Validation queue job bug-1067028-no-json-2012-10-15T20-46-42.007Z is finished. The final status was:

All tests succeeded!

Revision history for this message
Zorba Build Bot (zorba-buildbot) wrote :

Voting does not meet specified criteria. Required: Approve > 1, Disapprove < 1, Needs Fixing < 1, Pending < 1. Got: 1 Approve, 2 Pending.

Revision history for this message
Markos Zaharioudakis (markos-za) :
review: Approve
Revision history for this message
Zorba Build Bot (zorba-buildbot) wrote :

Attempt to merge into lp:zorba failed due to conflicts:

text conflict in src/compiler/rewriter/rules/type_rules.cpp

11101. By Chris Hillery

Merge from trunk.

11102. By Chris Hillery

Added ZORBA_WITH_JSON preprocessor guard for json-doc().

Revision history for this message
Zorba Build Bot (zorba-buildbot) wrote :
Revision history for this message
Zorba Build Bot (zorba-buildbot) wrote :

Validation queue job bug-1067028-no-json-2012-12-14T10-29-02.137Z is finished. The final status was:

All tests succeeded!

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'src/api/serialization/serializer.cpp'
2--- src/api/serialization/serializer.cpp 2012-10-08 12:09:36 +0000
3+++ src/api/serialization/serializer.cpp 2012-12-14 10:28:22 +0000
4@@ -2482,8 +2482,10 @@
5 case PARAMETER_VALUE_XHTML: m = "xhtml"; break;
6 case PARAMETER_VALUE_TEXT: m = "text"; break;
7 case PARAMETER_VALUE_BINARY: m = "binary"; break;
8+#ifdef ZORBA_WITH_JSON
9 case PARAMETER_VALUE_JSON: m = "json"; break;
10 case PARAMETER_VALUE_JSON_XML_HYBRID: m = "json-xml-hybrid"; break;
11+#endif
12 default: ZORBA_ASSERT(false);
13 }
14 }
15
16=== modified file 'src/compiler/rewriter/rules/type_rules.cpp'
17--- src/compiler/rewriter/rules/type_rules.cpp 2012-12-12 07:36:20 +0000
18+++ src/compiler/rewriter/rules/type_rules.cpp 2012-12-14 10:28:22 +0000
19@@ -129,6 +129,7 @@
20 return NULL;
21 }
22
23+#ifdef ZORBA_WITH_JSON
24 if (fo->get_func()->getKind() == FunctionConsts::OP_ZORBA_JSON_BOX_1)
25 {
26 expr* arg = fo->get_arg(0);
27@@ -147,6 +148,7 @@
28
29 return NULL;
30 }
31+#endif
32
33 break;
34 }
35
36=== modified file 'src/functions/pregenerated/func_jsoniq_functions.cpp'
37--- src/functions/pregenerated/func_jsoniq_functions.cpp 2012-10-15 13:39:36 +0000
38+++ src/functions/pregenerated/func_jsoniq_functions.cpp 2012-12-14 10:28:22 +0000
39@@ -141,7 +141,7 @@
40 }
41
42 #endif
43-
44+#ifdef ZORBA_WITH_JSON
45 PlanIter_t fn_jsoniq_json_doc::codegen(
46 CompilerCB*,
47 static_context* sctx,
48@@ -151,6 +151,8 @@
49 {
50 return new JSONDocIterator(sctx, loc, argv);
51 }
52+
53+#endif
54 #ifdef ZORBA_WITH_JSON
55 PlanIter_t op_zorba_json_item_accessor::codegen(
56 CompilerCB*,
57@@ -480,6 +482,8 @@
58 #endif
59
60
61+#ifdef ZORBA_WITH_JSON
62+
63
64 {
65 DECL_WITH_KIND(sctx, fn_jsoniq_json_doc,
66@@ -491,6 +495,8 @@
67 }
68
69
70+#endif
71+
72
73 #ifdef ZORBA_WITH_JSON
74
75
76=== modified file 'src/functions/pregenerated/func_jsoniq_functions.h'
77--- src/functions/pregenerated/func_jsoniq_functions.h 2012-10-15 13:39:36 +0000
78+++ src/functions/pregenerated/func_jsoniq_functions.h 2012-12-14 10:28:22 +0000
79@@ -236,7 +236,7 @@
80 CODEGEN_DECL();
81 };
82 #endif
83-
84+#ifdef ZORBA_WITH_JSON
85
86 //fn-jsoniq:json-doc
87 class fn_jsoniq_json_doc : public function
88@@ -255,6 +255,7 @@
89
90 CODEGEN_DECL();
91 };
92+#endif
93 #ifdef ZORBA_WITH_JSON
94
95 //op-zorba:json-item-accessor
96
97=== modified file 'src/runtime/json/pregenerated/jsoniq_functions.cpp'
98--- src/runtime/json/pregenerated/jsoniq_functions.cpp 2012-11-29 01:16:16 +0000
99+++ src/runtime/json/pregenerated/jsoniq_functions.cpp 2012-12-14 10:28:22 +0000
100@@ -357,6 +357,7 @@
101 // </JSONArrayFlattenIterator>
102
103 #endif
104+#ifdef ZORBA_WITH_JSON
105 // <JSONDocIterator>
106 SERIALIZABLE_CLASS_VERSIONS(JSONDocIterator)
107
108@@ -386,7 +387,7 @@
109
110 // </JSONDocIterator>
111
112-
113+#endif
114 #ifdef ZORBA_WITH_JSON
115 // <JSONItemAccessorIterator>
116 SERIALIZABLE_CLASS_VERSIONS(JSONItemAccessorIterator)
117
118=== modified file 'src/runtime/json/pregenerated/jsoniq_functions.h'
119--- src/runtime/json/pregenerated/jsoniq_functions.h 2012-11-29 01:16:16 +0000
120+++ src/runtime/json/pregenerated/jsoniq_functions.h 2012-12-14 10:28:22 +0000
121@@ -460,6 +460,7 @@
122
123 #endif
124
125+#ifdef ZORBA_WITH_JSON
126 /**
127 * jn:json-doc
128 * Author: Zorba Team
129@@ -505,6 +506,7 @@
130 bool nextImpl(store::Item_t& result, PlanState& aPlanState) const;
131 };
132
133+#endif
134
135 #ifdef ZORBA_WITH_JSON
136 /**
137
138=== modified file 'src/runtime/spec/json/jsoniq_functions.xml'
139--- src/runtime/spec/json/jsoniq_functions.xml 2012-11-29 01:16:16 +0000
140+++ src/runtime/spec/json/jsoniq_functions.xml 2012-12-14 10:28:22 +0000
141@@ -388,7 +388,8 @@
142 /*******************************************************************************
143 ********************************************************************************/
144 -->
145-<zorba:iterator name="JSONDocIterator">
146+<zorba:iterator name="JSONDocIterator"
147+ preprocessorGuard="#ifdef ZORBA_WITH_JSON">
148
149 <zorba:description author="Zorba Team">jn:json-doc</zorba:description>
150
151
152=== modified file 'src/runtime/visitors/pregenerated/planiter_visitor.h'
153--- src/runtime/visitors/pregenerated/planiter_visitor.h 2012-10-15 13:39:36 +0000
154+++ src/runtime/visitors/pregenerated/planiter_visitor.h 2012-12-14 10:28:22 +0000
155@@ -338,8 +338,9 @@
156 #ifdef ZORBA_WITH_JSON
157 class JSONArrayFlattenIterator;
158 #endif
159+#ifdef ZORBA_WITH_JSON
160 class JSONDocIterator;
161-
162+#endif
163 #ifdef ZORBA_WITH_JSON
164 class JSONItemAccessorIterator;
165 #endif
166@@ -1190,9 +1191,10 @@
167 virtual void beginVisit ( const JSONArrayFlattenIterator& ) = 0;
168 virtual void endVisit ( const JSONArrayFlattenIterator& ) = 0;
169 #endif
170+#ifdef ZORBA_WITH_JSON
171 virtual void beginVisit ( const JSONDocIterator& ) = 0;
172 virtual void endVisit ( const JSONDocIterator& ) = 0;
173-
174+#endif
175 #ifdef ZORBA_WITH_JSON
176 virtual void beginVisit ( const JSONItemAccessorIterator& ) = 0;
177 virtual void endVisit ( const JSONItemAccessorIterator& ) = 0;
178
179=== modified file 'src/runtime/visitors/pregenerated/printer_visitor.cpp'
180--- src/runtime/visitors/pregenerated/printer_visitor.cpp 2012-10-15 13:39:36 +0000
181+++ src/runtime/visitors/pregenerated/printer_visitor.cpp 2012-12-14 10:28:22 +0000
182@@ -1973,7 +1973,7 @@
183 // </JSONArrayFlattenIterator>
184
185 #endif
186-
187+#ifdef ZORBA_WITH_JSON
188 // <JSONDocIterator>
189 void PrinterVisitor::beginVisit ( const JSONDocIterator& a) {
190 thePrinter.startBeginVisit("JSONDocIterator", ++theId);
191@@ -1987,6 +1987,7 @@
192 }
193 // </JSONDocIterator>
194
195+#endif
196 #ifdef ZORBA_WITH_JSON
197 // <JSONItemAccessorIterator>
198 void PrinterVisitor::beginVisit ( const JSONItemAccessorIterator& a) {
199
200=== modified file 'src/runtime/visitors/pregenerated/printer_visitor.h'
201--- src/runtime/visitors/pregenerated/printer_visitor.h 2012-10-15 13:39:36 +0000
202+++ src/runtime/visitors/pregenerated/printer_visitor.h 2012-12-14 10:28:22 +0000
203@@ -522,8 +522,10 @@
204 void endVisit ( const JSONArrayFlattenIterator& );
205 #endif
206
207+#ifdef ZORBA_WITH_JSON
208 void beginVisit( const JSONDocIterator& );
209 void endVisit ( const JSONDocIterator& );
210+#endif
211
212 #ifdef ZORBA_WITH_JSON
213 void beginVisit( const JSONItemAccessorIterator& );

Subscribers

People subscribed via source and target branches