Merge lp:~zorba-coders/zorba/bug-1041411 into lp:zorba

Proposed by Ghislain Fourny
Status: Merged
Approved by: Matthias Brantner
Approved revision: 11015
Merged at revision: 11017
Proposed branch: lp:~zorba-coders/zorba/bug-1041411
Merge into: lp:zorba
Diff against target: 25 lines (+4/-1)
3 files modified
src/compiler/translator/translator.cpp (+1/-1)
test/rbkt/Queries/zorba/jsoniq/prefixed_true.spec (+2/-0)
test/rbkt/Queries/zorba/jsoniq/prefixed_true.xq (+1/-0)
To merge this branch: bzr merge lp:~zorba-coders/zorba/bug-1041411
Reviewer Review Type Date Requested Status
Matthias Brantner Approve
Chris Hillery Approve
Review via email: mp+122265@code.launchpad.net

Commit message

Fixed bug 1041411 (prefixed true/false/null should be interpreted as name tests).

Description of the change

To post a comment you must log in.
Revision history for this message
Zorba Build Bot (zorba-buildbot) wrote :
Revision history for this message
Zorba Build Bot (zorba-buildbot) wrote :

Validation queue job bug-1041411-2012-08-31T13-08-54.834Z is finished. The final status was:

All tests succeeded!

Revision history for this message
Zorba Build Bot (zorba-buildbot) wrote :

Voting does not meet specified criteria. Required: Approve > 1, Disapprove < 1, Needs Fixing < 1, Pending < 1. Got: 2 Pending.

Revision history for this message
Chris Hillery (ceejatec) :
review: Approve
Revision history for this message
Chris Hillery (ceejatec) wrote :

Also, did you get a chance to update the spec as mentioned in the bug?

Revision history for this message
Matthias Brantner (matthias-brantner) :
review: Approve
Revision history for this message
Zorba Build Bot (zorba-buildbot) wrote :
Revision history for this message
Zorba Build Bot (zorba-buildbot) wrote :

Validation queue job bug-1041411-2012-08-31T20-00-53.951Z is finished. The final status was:

All tests succeeded!

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'src/compiler/translator/translator.cpp'
2--- src/compiler/translator/translator.cpp 2012-08-30 13:45:43 +0000
3+++ src/compiler/translator/translator.cpp 2012-08-31 12:48:19 +0000
4@@ -8666,7 +8666,7 @@
5 {
6 const rchandle<QName> lQName = lNodetest->getQName();
7
8- if (lQName && lQName->get_namespace() == "")
9+ if (lQName && lQName->get_prefix() == "")
10 {
11 const zstring& lLocal = lQName->get_localname();
12
13
14=== added file 'test/rbkt/Queries/zorba/jsoniq/prefixed_true.spec'
15--- test/rbkt/Queries/zorba/jsoniq/prefixed_true.spec 1970-01-01 00:00:00 +0000
16+++ test/rbkt/Queries/zorba/jsoniq/prefixed_true.spec 2012-08-31 12:48:19 +0000
17@@ -0,0 +1,2 @@
18+Serialization: method=json
19+Error: http://www.w3.org/2005/xqt-errors:XPDY0002
20
21=== added file 'test/rbkt/Queries/zorba/jsoniq/prefixed_true.xq'
22--- test/rbkt/Queries/zorba/jsoniq/prefixed_true.xq 1970-01-01 00:00:00 +0000
23+++ test/rbkt/Queries/zorba/jsoniq/prefixed_true.xq 2012-08-31 12:48:19 +0000
24@@ -0,0 +1,1 @@
25+xs:true

Subscribers

People subscribed via source and target branches