Merge lp:~zorba-coders/zorba/bug-1021362 into lp:zorba

Proposed by Dennis Knochenwefel
Status: Merged
Approved by: Dennis Knochenwefel
Approved revision: 10914
Merged at revision: 10915
Proposed branch: lp:~zorba-coders/zorba/bug-1021362
Merge into: lp:zorba
Diff against target: 34 lines (+16/-6)
1 file modified
CMakeLists.txt (+16/-6)
To merge this branch: bzr merge lp:~zorba-coders/zorba/bug-1021362
Reviewer Review Type Date Requested Status
Paul J. Lucas Approve
Dennis Knochenwefel Approve
Review via email: mp+113604@code.launchpad.net

Commit message

fixed CHECK_CXX_SOURCE_COMPILES doesn't work with backslash-n using cmake 2.8.8 on windows.

Description of the change

fix for bug #1021362

To post a comment you must log in.
Revision history for this message
Zorba Build Bot (zorba-buildbot) wrote :
Revision history for this message
Zorba Build Bot (zorba-buildbot) wrote :

Validation queue job bug-1021362-2012-07-05T16-00-00.091Z is finished. The final status was:

All tests succeeded!

Revision history for this message
Zorba Build Bot (zorba-buildbot) wrote :

Voting does not meet specified criteria. Required: Approve > 1, Disapprove < 1, Needs Fixing < 1, Pending < 1. Got: 1 Pending.

Revision history for this message
Dennis Knochenwefel (dennis-knochenwefel) :
review: Approve
Revision history for this message
Paul J. Lucas (paul-lucas) :
review: Approve
Revision history for this message
Zorba Build Bot (zorba-buildbot) wrote :
Revision history for this message
Zorba Build Bot (zorba-buildbot) wrote :

Validation queue job bug-1021362-2012-07-05T17-21-23.64Z is finished. The final status was:

All tests succeeded!

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'CMakeLists.txt'
2--- CMakeLists.txt 2012-06-28 15:05:15 +0000
3+++ CMakeLists.txt 2012-07-05 15:59:24 +0000
4@@ -137,14 +137,24 @@
5 SET(CMAKE_EXTRA_INCLUDE_FILES)
6
7 # C++11 langauge features
8-CHECK_CXX_SOURCE_COMPILES("int main() { int *p = nullptr; }" ZORBA_CXX_NULLPTR)
9-CHECK_CXX_SOURCE_COMPILES("int main() { static_assert(1,\"\"); }" ZORBA_CXX_STATIC_ASSERT)
10+CHECK_CXX_SOURCE_COMPILES(
11+ "int main() { int *p = nullptr; }" ZORBA_CXX_NULLPTR)
12+CHECK_CXX_SOURCE_COMPILES(
13+ "int main() { static_assert(1,\"\"); }" ZORBA_CXX_STATIC_ASSERT)
14
15 # C++11 standard library types
16-CHECK_CXX_SOURCE_COMPILES ("#include <type_traits>\nint main() { std::enable_if<true,int> x; }" ZORBA_HAVE_ENABLE_IF)
17-CHECK_CXX_SOURCE_COMPILES ("#include <memory>\nint main() { std::unique_ptr<int> p; }" ZORBA_HAVE_UNIQUE_PTR)
18-CHECK_CXX_SOURCE_COMPILES ("#include <unordered_map>\nint main() { std::unordered_map<int,int> m; }" ZORBA_HAVE_UNORDERED_MAP)
19-CHECK_CXX_SOURCE_COMPILES ("#include <unordered_set>\nint main() { std::unordered_set<int> s; }" ZORBA_HAVE_UNORDERED_SET)
20+CHECK_CXX_SOURCE_COMPILES (
21+ "#include <type_traits>
22+ int main() { std::enable_if<true,int> x; }" ZORBA_HAVE_ENABLE_IF)
23+CHECK_CXX_SOURCE_COMPILES ("
24+ #include <memory>
25+ int main() { std::unique_ptr<int> p; }" ZORBA_HAVE_UNIQUE_PTR)
26+CHECK_CXX_SOURCE_COMPILES (
27+ "#include <unordered_map>
28+ int main() { std::unordered_map<int,int> m; }" ZORBA_HAVE_UNORDERED_MAP)
29+CHECK_CXX_SOURCE_COMPILES (
30+ "#include <unordered_set>
31+ int main() { std::unordered_set<int> s; }" ZORBA_HAVE_UNORDERED_SET)
32
33 ################################################################################
34 # Various cmake macros

Subscribers

People subscribed via source and target branches