Merge lp:~zorba-coders/zorba/archive-module-win64 into lp:zorba/archive-module

Proposed by Juan Zacarias
Status: Merged
Merged at revision: 54
Proposed branch: lp:~zorba-coders/zorba/archive-module-win64
Merge into: lp:zorba/archive-module
Diff against target: 94 lines (+19/-22)
2 files modified
src/archive_module.xq.src/archive_module.cpp (+7/-11)
src/archive_module.xq.src/archive_module.h (+12/-11)
To merge this branch: bzr merge lp:~zorba-coders/zorba/archive-module-win64
Reviewer Review Type Date Requested Status
Juan Zacarias Approve
Chris Hillery Approve
Review via email: mp+178845@code.launchpad.net

Commit message

Fixes for Windows64

Description of the change

Fixes for Windows64

To post a comment you must log in.
Revision history for this message
Chris Hillery (ceejatec) :
review: Approve
Revision history for this message
Zorba Build Bot (zorba-buildbot) wrote :

Validation queue starting for the following merge proposals:
https://code.launchpad.net/~zorba-coders/zorba/archive-module-win64/+merge/178845

Progress dashboard at http://jenkins.lambda.nu/view/ValidationQueue

Revision history for this message
Juan Zacarias (juan457) :
review: Approve
Revision history for this message
Zorba Build Bot (zorba-buildbot) wrote :

Validation queue succeeded - proposal merged!

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'src/archive_module.xq.src/archive_module.cpp'
2--- src/archive_module.xq.src/archive_module.cpp 2013-07-31 22:00:40 +0000
3+++ src/archive_module.xq.src/archive_module.cpp 2013-08-06 20:42:32 +0000
4@@ -27,9 +27,11 @@
5 # include <sys/time.h>
6 #endif
7 #ifdef WIN32
8-# include <strptime.h>
9+# include "strptime.h"
10+#ifndef _WIN64
11 # include <MMSystem.h>
12 #endif
13+#endif
14
15 #include <zorba/diagnostic_list.h>
16 #include <zorba/empty_sequence.h>
17@@ -890,11 +892,8 @@
18 ArchiveFunction::checkForError(lErr, 0, a);
19 }
20
21-#ifdef WIN32
22- long
23-#else
24- ssize_t
25-#endif
26+
27+ _ssize_t
28 ArchiveItemSequence::readStream(struct archive*, void *data, const void **buff)
29 {
30 ArchiveItemSequence::CallbackData* lData =
31@@ -987,11 +986,8 @@
32 theArchive = 0;
33 }
34
35-#ifdef WIN32
36- long
37-#else
38- ssize_t
39-#endif
40+
41+ _ssize_t
42 ArchiveFunction::writeStream(
43 struct archive *,
44 void *func,
45
46=== modified file 'src/archive_module.xq.src/archive_module.h'
47--- src/archive_module.xq.src/archive_module.h 2013-07-29 19:24:56 +0000
48+++ src/archive_module.xq.src/archive_module.h 2013-08-06 20:42:32 +0000
49@@ -32,9 +32,16 @@
50 #define ZORBA_ARCHIVE_COMPRESSION_DEFLATE 50
51 #define ZORBA_ARCHIVE_COMPRESSION_STORE 51
52
53-
54 namespace zorba { namespace archive {
55
56+#ifdef _WIN64
57+ typedef long long _ssize_t;
58+#elif WIN32
59+ typedef long _ssize_t;
60+#else
61+ typedef ssize_t _ssize_t;
62+#endif
63+
64 /*******************************************************************************
65 ******************************************************************************/
66 class ArchiveModule : public ExternalModule {
67@@ -165,11 +172,8 @@
68 virtual ~ArchiveItemSequence() {}
69
70 protected:
71-#ifdef WIN32
72- static long
73-#else
74- static ssize_t
75-#endif
76+
77+ static _ssize_t
78 readStream(struct archive *a, void *client_data, const void **buff);
79
80 // needed for the "non-linear" zip format
81@@ -323,11 +327,8 @@
82 static zorba::Item
83 getOneItem(const Arguments_t& aArgs, int aIndex);
84
85-#ifdef WIN32
86- static long
87-#else
88- static ssize_t
89-#endif
90+
91+ static _ssize_t
92 writeStream(struct archive *a, void *client_data, const void *buff, size_t n);
93
94 static int

Subscribers

People subscribed via source and target branches

to all changes: